Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: ui/base/platform_window_defaults.h

Issue 2683033006: Move SetUseOverrideRedirectWindowByDefault() to //ui/base. (Closed)
Patch Set: Rename files. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/base/BUILD.gn ('k') | ui/base/platform_window_defaults.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/platform_window_defaults.h
diff --git a/ui/base/platform_window_defaults.h b/ui/base/platform_window_defaults.h
new file mode 100644
index 0000000000000000000000000000000000000000..ff9af2e386547923300ee01b74b94abe616a6282
--- /dev/null
+++ b/ui/base/platform_window_defaults.h
@@ -0,0 +1,30 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef UI_BASE_PLATFORM_WINDOW_DEFAULTS_H_
+#define UI_BASE_PLATFORM_WINDOW_DEFAULTS_H_
+
+#include "ui/base/ui_base_export.h"
+
+namespace ui {
+
+// Gets the |override_redirect| flag used when creating an X11 window.
+UI_BASE_EXPORT bool GetUseOverrideRedirectWindowByDefault();
+
+namespace test {
+
+// Sets the value of the |override_redirect| flag when creating an X11 window.
+// It is necessary to set this flag on for various tests, otherwise the call to
+// Show() blocks because it never receives the MapNotify event. It is unclear
+// why this is necessary, but might be related to calls to XInitThreads().
+//
+// This can be called safely on all platforms. For non-X11 platforms it will
+// have no effect.
+UI_BASE_EXPORT void SetUseOverrideRedirectWindowByDefault(
sadrul 2017/02/09 21:49:35 Maybe call this something different? like EnableTe
kylechar 2017/02/10 15:31:03 Done.
+ bool override_redirect);
+
+} // namespace test
+} // namespace ui
+
+#endif // UI_BASE_PLATFORM_WINDOW_DEFAULTS_H_
« no previous file with comments | « ui/base/BUILD.gn ('k') | ui/base/platform_window_defaults.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698