media/base/channel_layout.h - Issue 2683033003: Tell CoreAudio how to interpret Chrome's channel layout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/channel_layout.h

Issue 2683033003: Tell CoreAudio how to interpret Chrome's channel layout. (Closed)

Patch Set: Fix 8ch+ discrete layouts. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/base/channel_layout.h

diff --git a/media/base/channel_layout.h b/media/base/channel_layout.h

index d44a746a61f3e85e84fe793eefdf84c52a689ec9..33575882f94e5d37200606893276d59da8cb9755 100644

--- a/media/base/channel_layout.h

+++ b/media/base/channel_layout.h

@@ -112,6 +112,8 @@ enum ChannelLayout {

CHANNEL_LAYOUT_MAX = CHANNEL_LAYOUT_4_1_QUAD_SIDE

};

+// Note: Do not reorder or reassign these values; other code depends on their

+// ordering to operate correctly. E.g., CoreAudio channel layout computations.

enum Channels {

LEFT = 0,

RIGHT,

« no previous file with comments | « media/audio/mac/audio_auhal_mac.cc ('k') | no next file » | no next file with comments »