Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: media/base/channel_layout.h

Issue 2683033003: Tell CoreAudio how to interpret Chrome's channel layout. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« media/audio/mac/audio_auhal_mac.cc ('K') | « media/audio/mac/audio_auhal_mac.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/channel_layout.h
diff --git a/media/base/channel_layout.h b/media/base/channel_layout.h
index d44a746a61f3e85e84fe793eefdf84c52a689ec9..0d3d3c6f461cf76fb2bd2252486f8a40d3c28768 100644
--- a/media/base/channel_layout.h
+++ b/media/base/channel_layout.h
@@ -112,6 +112,8 @@ enum ChannelLayout {
CHANNEL_LAYOUT_MAX = CHANNEL_LAYOUT_4_1_QUAD_SIDE
};
+// Note: Do not reorder or reassign these values; other code depends on their
+// ordering to operate correctly. E.g., OSX channel layout computations.
Avi (use Gerrit) 2017/02/09 02:44:38 macOS
DaleCurtis 2017/02/09 03:18:39 Switched in favor of CoreAudio.
enum Channels {
LEFT = 0,
RIGHT,
« media/audio/mac/audio_auhal_mac.cc ('K') | « media/audio/mac/audio_auhal_mac.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698