Issue 268303004: Move SVGElement::finishParsingChildren to SVGSVGElement

Issue 268303004: Move SVGElement::finishParsingChildren to SVGSVGElement (Closed)

Created:
6 years, 7 months ago by rwlbuis

Modified:
6 years, 7 months ago

Reviewers:
pdr.

CC:
blink-reviews, krit, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, kouhei+svg_chromium.org, pdr., rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Move SVGElement::finishParsingChildren to SVGSVGElement Move SVGElement::finishParsingChildren to SVGSVGElement since it only performs actions on <svg>. This means we have to do one less check and SVG elements other than <svg> will have faster execution for finishParsingChildren. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173463

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix nit #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -15 lines)			Patch
M	Source/core/svg/SVGElement.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/svg/SVGElement.cpp	View		1 chunk	+0 lines, -14 lines	0 comments	Download
M	Source/core/svg/SVGSVGElement.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/svg/SVGSVGElement.cpp	View	1	1 chunk	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

pdr.

LGTM with a nit. https://codereview.chromium.org/268303004/diff/1/Source/core/svg/SVGSVGElement.cpp File Source/core/svg/SVGSVGElement.cpp (right): https://codereview.chromium.org/268303004/diff/1/Source/core/svg/SVGSVGElement.cpp#newcode775 Source/core/svg/SVGSVGElement.cpp:775: SVGElement::finishParsingChildren(); Nit: please call SVGGraphicsElement::finishParsingChildren();

6 years, 7 months ago (2014-05-06 22:53:42 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/268303004/20001

6 years, 7 months ago (2014-05-07 02:01:03 UTC) #6

Message was sent while issue was closed.

Change committed as 173463

Expand Messages | Collapse Messages