Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Issue 2682943009: Fix socket_source_address_test (Closed)

Created:
3 years, 10 months ago by Florian Schneider
Modified:
3 years, 10 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : another fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M tests/standalone/io/socket_source_address_test.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Florian Schneider
Seems like a bug in the test if I understand it correctly.
3 years, 10 months ago (2017-02-10 03:59:51 UTC) #2
kustermann
LGTM
3 years, 10 months ago (2017-02-10 17:09:17 UTC) #3
Florian Schneider
3 years, 10 months ago (2017-02-10 17:11:50 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
5b8d96989f58ed0714c33d9abcc7a41240caa44b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698