Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: third_party/WebKit/Source/platform/heap/ThreadState.cpp

Issue 2682933003: Remove a thread-local termination GC (Closed)
Patch Set: temp Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/heap/BlinkGC.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/heap/ThreadState.cpp
diff --git a/third_party/WebKit/Source/platform/heap/ThreadState.cpp b/third_party/WebKit/Source/platform/heap/ThreadState.cpp
index a656dfecef2e02a9c2983e0263dc42c4602ed4d9..6034024373f964b8d177132e22129f6379ebdc05 100644
--- a/third_party/WebKit/Source/platform/heap/ThreadState.cpp
+++ b/third_party/WebKit/Source/platform/heap/ThreadState.cpp
@@ -233,6 +233,8 @@ void ThreadState::runTerminationGC() {
// Set the terminate flag on all heap pages of this thread. This is used to
// ensure we don't trace pages on other threads that are not part of the
// thread local GC.
+ // TODO(haraken): Remove this. This is not needed once we remove a thread-
sof 2017/02/08 12:06:19 oh, i suppose that is now possible with orphaned p
+ // local termination GC.
prepareForThreadStateTermination();
ProcessHeap::crossThreadPersistentRegion().prepareForThreadStateTermination(
@@ -244,7 +246,8 @@ void ThreadState::runTerminationGC() {
int currentCount = getPersistentRegion()->numberOfPersistents();
ASSERT(currentCount >= 0);
while (currentCount != oldCount) {
- collectGarbageForTerminatingThread();
+ collectGarbage(BlinkGC::NoHeapPointersOnStack, BlinkGC::GCWithSweep,
+ BlinkGC::ThreadTerminationGC);
// Release the thread-local static persistents that were
// instantiated while running the termination GC.
releaseStaticPersistentNodes();
« no previous file with comments | « third_party/WebKit/Source/platform/heap/BlinkGC.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698