Source/devtools/front_end/sources/SourcesView.js - Issue 268293003: DevTools: Get rid of WebInspector.panels

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/sources/SourcesView.js

Issue 268293003: DevTools: Get rid of WebInspector.panels (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/devtools/front_end/sources/SourcesView.js

diff --git a/Source/devtools/front_end/sources/SourcesView.js b/Source/devtools/front_end/sources/SourcesView.js

index a384800d3274f73260cd666b400f95cb2bf31ced..fd01a972bbbf2eed35627c26d23cd9143d24f688 100644

--- a/Source/devtools/front_end/sources/SourcesView.js

+++ b/Source/devtools/front_end/sources/SourcesView.js

@@ -77,7 +77,7 @@ WebInspector.SourcesView = function(workspace, sourcesPanel)

event.returnValue = WebInspector.UIString("DevTools have unsaved changes that will be permanently lost.");

WebInspector.inspectorView.showPanel("sources");

for (var i = 0; i < unsavedSourceCodes.length; ++i)

- WebInspector.panels.sources.showUISourceCode(unsavedSourceCodes[i]);

+ WebInspector.inspectorView.panel("sources").showUISourceCode(unsavedSourceCodes[i]);

pfeldman 2014/05/06 19:57:14 You should plumb delegates instead.

apavlov 2014/05/07 10:26:13 Agree. My point was to do mechanical changes first

}

window.addEventListener("beforeunload", handleBeforeUnload, true);