DevTools: Get rid of WebInspector.panels

Source/devtools/front_end/ui/InspectorView.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 51 matching lines @@
     this._errorWarningCountElement = this._rightToolbarElement.createChild("div", "hidden");
     this._errorWarningCountElement.id = "error-warning-count";
 
     this._closeButtonToolbarItem = document.createElementWithClass("div", "toolbar-close-button-item");
     var closeButtonElement = this._closeButtonToolbarItem.createChild("div", "close-button");
     closeButtonElement.addEventListener("click", InspectorFrontendHost.closeWindow.bind(InspectorFrontendHost), true);
     this._rightToolbarElement.appendChild(this._closeButtonToolbarItem);
 
     this.appendToRightToolbar(this._drawer.toggleButtonElement());
 
+    this._panels = {};
+    // Used by tests.
+    WebInspector["panels"] = this._panels;
+
     this._history = [];
     this._historyIterator = -1;
     document.addEventListener("keydown", this._keyDown.bind(this), false);
     document.addEventListener("keypress", this._keyPress.bind(this), false);
     this._panelDescriptors = {};
 
     // Windows and Mac have two different definitions of '[' and ']', so accept both of each.
     this._openBracketIdentifiers = ["U+005B", "U+00DB"].keySet();
     this._closeBracketIdentifiers = ["U+005D", "U+00DD"].keySet();
     this._lastActivePanelSetting = WebInspector.settings.createSetting("lastActivePanel", "elements");
@@ skipping 40 matching lines @@
     {
         var panelName = panelDescriptor.name();
         this._panelDescriptors[panelName] = panelDescriptor;
         this._tabbedPane.appendTab(panelName, panelDescriptor.title(), new WebInspector.View());
         if (this._lastActivePanelSetting.get() === panelName)
             this._tabbedPane.selectTab(panelName);
     },
 
     /**
      * @param {string} panelName
+     * @return {boolean}
+     */
+    hasPanel: function(panelName)
+    {
+        return !!this._panelDescriptors[panelName];
+    },
+
+    /**
+     * @param {string} panelName
      * @return {?WebInspector.Panel}
      */
     panel: function(panelName)
     {
         var panelDescriptor = this._panelDescriptors[panelName];
         var panelOrder = this._tabbedPane.allTabs();
         if (!panelDescriptor && panelOrder.length)
             panelDescriptor = this._panelDescriptors[panelOrder[0]];
-        return panelDescriptor ? panelDescriptor.panel() : null;
+        var panel = panelDescriptor ? panelDescriptor.panel() : null;
+        if (panel)
+            this._panels[panelName] = panel;
+        return panel;
     },
 
     /**
      * @param {string} panelName
      * @return {?WebInspector.Panel}
      */
     showPanel: function(panelName)
     {
         var panel = this.panel(panelName);
         if (panel)
@@ skipping 41 matching lines @@
     {
         this._drawer.setDrawerEditorAvailable(available);
     },
 
     _tabSelected: function()
     {
         var panelName = this._tabbedPane.selectedTabId;
         if (!panelName)
             return;
         var panel = this._panelDescriptors[this._tabbedPane.selectedTabId].panel();
+        this._panels[panelName] = panel;
         this._tabbedPane.changeTabView(panelName, panel);
 
         this._currentPanel = panel;
         this._lastActivePanelSetting.set(panel.name);
         this._pushToHistory(panel.name);
         WebInspector.userMetrics.panelShown(panel.name);
         panel.focus();
     },
 
     /**
@@ skipping 149 matching lines @@
 
     _moveInHistory: function(move)
     {
         var newIndex = this._historyIterator + move;
         if (newIndex >= this._history.length || newIndex < 0)
             return false;
 
         this._inHistory = true;
         this._historyIterator = newIndex;
         if (!WebInspector.Dialog.currentInstance())
-            this.setCurrentPanel(WebInspector.panels[this._history[this._historyIterator]]);
+            this.setCurrentPanel(this._panels[this._history[this._historyIterator]]);
         delete this._inHistory;
 
         return true;
     },
 
     _pushToHistory: function(panelName)
     {
         if (this._inHistory)
             return;
 
@@ skipping 123 matching lines @@
             window.addEventListener("scroll", this._onScrollBound, false);
         else
             window.removeEventListener("scroll", this._onScrollBound, false);
 
         WebInspector.VBox.prototype.doResize.call(this);
         this._onScroll();
     },
 
     __proto__: WebInspector.VBox.prototype
 };