DevTools: Get rid of WebInspector.panels

Source/devtools/front_end/profiler/ProfilesPanel.js

 /*
  * Copyright (C) 2008 Apple Inc. All Rights Reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 293 matching lines @@
     /**
      * Must be implemented by subclasses.
      * @return {!WebInspector.ProfileSidebarTreeElement}
      */
     createSidebarTreeElement: function()
     {
         throw new Error("Needs implemented.");
     },
 
     /**
+     * @param {!WebInspector.ProfilesPanel} panel
      * @return {!WebInspector.View}
      */
-    createView: function()
+    createView: function(panel)
     {
         throw new Error("Not implemented.");
     },
 
     removeTempFile: function()
     {
         if (this._tempFile)
             this._tempFile.remove();
     },
 
@@ skipping 95 matching lines @@
     this._profileViewStatusBarItemsContainer = this._statusBarElement.createChild("div");
 
     this._profileGroups = {};
     this._launcherView = new WebInspector.MultiProfileLauncherView(this);
     this._launcherView.addEventListener(WebInspector.MultiProfileLauncherView.EventTypes.ProfileTypeSelected, this._onProfileTypeSelected, this);
 
     this._profileToView = [];
     this._typeIdToSidebarSection = {};
     var types = WebInspector.ProfileTypeRegistry.instance.profileTypes();
     for (var i = 0; i < types.length; i++)
         this._registerProfileType(types[i]);

[yurys, 2014/05/07 14:43:41]

Let's register panel as a listener for
HeapSnapshotProfileType.Events.ProfileComplete on
WebInspector.ProfileTypeRegistry.heapSnapshotProfileType and
WebInspector.ProfileTypeRegistry.trackingHeapSnapshotProfileType here. The
listener will call this.showProfile. This way we can get rid of the new
Revealer.

[apavlov, 2014/05/07 15:54:23]

Done.

     this._launcherView.restoreSelectedProfileType();
     this.profilesItemTreeElement.select();
     this._showLauncherView();
 
     this._createFileSelectorElement();
     this.element.addEventListener("contextmenu", this._handleContextMenuEvent.bind(this), true);
     this._registerShortcuts();
 
     this._configureCpuProfilerSamplingInterval();
     WebInspector.settings.highResolutionCpuProfiling.addChangeListener(this._configureCpuProfilerSamplingInterval, this);
@@ skipping 383 matching lines @@
 
     /**
      * @param {!WebInspector.ProfileHeader} profile
      * @return {!WebInspector.View}
      */
     _viewForProfile: function(profile)
     {
         var index = this._indexOfViewForProfile(profile);
         if (index !== -1)
             return this._profileToView[index].view;
-        var view = profile.createView();
+        var view = profile.createView(this);
         view.element.classList.add("profile-view");
         this._profileToView.push({ profile: profile, view: view});
         return view;
     },
 
     /**
      * @param {!WebInspector.ProfileHeader} profile
      * @return {number}
      */
     _indexOfViewForProfile: function(profile)
@@ skipping 282 matching lines @@
      * @param {!Object} target
      */
     appendApplicableItems: function(event, contextMenu, target)
     {
         WebInspector.inspectorView.panel("profiles").appendApplicableItems(event, contextMenu, target);
     }
 }
 
 /**
  * @constructor
+ * @implements {WebInspector.Revealer}
+ */
+WebInspector.ProfilesPanel.ProfileRevealer = function()
+{
+}
+
+WebInspector.ProfilesPanel.ProfileRevealer.prototype = {
+    /**
+     * @param {!Object} profile
+     */
+    reveal: function(profile)
+    {
+        if (profile instanceof WebInspector.ProfileHeader)
+            /** @type {!WebInspector.ProfilesPanel} */ (WebInspector.inspectorView.panel("profiles")).showProfile(profile);
+    }
+}
+
+/**
+ * @constructor
  * @extends {WebInspector.SidebarTreeElement}
  * @param {!WebInspector.ProfileHeader} profile
  * @param {string} className
  */
 WebInspector.ProfileSidebarTreeElement = function(profile, className)
 {
     this.profile = profile;
     WebInspector.SidebarTreeElement.call(this, className, profile.title, "", profile, false);
     this.refreshTitles();
     profile.addEventListener(WebInspector.ProfileHeader.Events.UpdateStatus, this._updateStatus, this);
@@ skipping 30 matching lines @@
     },
 
     dispose: function()
     {
         this.profile.removeEventListener(WebInspector.ProfileHeader.Events.UpdateStatus, this._updateStatus, this);
         this.profile.removeEventListener(WebInspector.ProfileHeader.Events.ProfileReceived, this._onProfileReceived, this);
     },
 
     onselect: function()
     {
-        WebInspector.panels.profiles.showProfile(this.profile);
+        WebInspector.Revealer.reveal(this.profile);

[yurys, 2014/05/07 14:43:41]

We can store panel reference in a field.

[apavlov, 2014/05/07 15:54:23]

Done.

     },
 
     /**
      * @return {boolean}
      */
     ondelete: function()
     {
         this.profile.profileType().removeProfile(this.profile);
         return true;
     },
@@ skipping 30 matching lines @@
  */
 WebInspector.ProfileGroupSidebarTreeElement = function(title, subtitle)
 {
     WebInspector.SidebarTreeElement.call(this, "profile-group-sidebar-tree-item", title, subtitle, null, true);
 }
 
 WebInspector.ProfileGroupSidebarTreeElement.prototype = {
     onselect: function()
     {
         if (this.children.length > 0)
-            WebInspector.panels.profiles.showProfile(this.children[this.children.length - 1].profile);
+            WebInspector.Revealer.reveal(this.children[this.children.length - 1].profile);
     },
 
     __proto__: WebInspector.SidebarTreeElement.prototype
 }
 
 /**
  * @constructor
  * @extends {WebInspector.SidebarTreeElement}
  * @param {!WebInspector.ProfilesPanel} panel
  */
@@ skipping 29 matching lines @@
 importScript("HeapSnapshotCommon.js");
 importScript("HeapSnapshotProxy.js");
 importScript("HeapSnapshotDataGrids.js");
 importScript("HeapSnapshotGridNodes.js");
 importScript("HeapSnapshotView.js");
 importScript("ProfileLauncherView.js");
 importScript("CanvasProfileView.js");
 importScript("CanvasReplayStateView.js");
 
 WebInspector.ProfileTypeRegistry.instance = new WebInspector.ProfileTypeRegistry();