DevTools: Get rid of WebInspector.panels

Source/devtools/front_end/profiler/HeapSnapshotView.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 13 matching lines @@
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 /**
  * @constructor
  * @extends {WebInspector.VBox}
+ * @param {!WebInspector.ProfilesPanel} panel
  * @param {!WebInspector.HeapProfileHeader} profile
  */
-WebInspector.HeapSnapshotView = function(profile)
+WebInspector.HeapSnapshotView = function(panel, profile)
 {
     WebInspector.VBox.call(this);
 
     this.element.classList.add("heap-snapshot-view");
 
     profile.profileType().addEventListener(WebInspector.HeapSnapshotProfileType.SnapshotReceived, this._onReceiveSnapshot, this);
     profile.profileType().addEventListener(WebInspector.ProfileType.Events.RemoveProfileHeader, this._onProfileHeaderRemoved, this);
 
     if (profile._profileType.id === WebInspector.TrackingHeapSnapshotProfileType.TypeId) {
         this._trackingOverviewGrid = new WebInspector.HeapTrackingOverviewGrid(profile);
         this._trackingOverviewGrid.addEventListener(WebInspector.HeapTrackingOverviewGrid.IdsRangeChanged, this._onIdsRangeChanged.bind(this));
     }
 
     this._splitView = new WebInspector.SplitView(false, true, "heapSnapshotSplitViewState", 200, 200);
     this._splitView.show(this.element);
 
     this._containmentView = new WebInspector.VBox();
     this._containmentView.setMinimumSize(50, 25);
-    this._containmentDataGrid = new WebInspector.HeapSnapshotContainmentDataGrid();
+    this._containmentDataGrid = new WebInspector.HeapSnapshotContainmentDataGrid(panel);
     this._containmentDataGrid.show(this._containmentView.element);
     this._containmentDataGrid.addEventListener(WebInspector.DataGrid.Events.SelectedNode, this._selectionChanged, this);
 
     this._statisticsView = new WebInspector.HeapSnapshotStatisticsView();
 
     this._constructorsView = new WebInspector.VBox();
     this._constructorsView.setMinimumSize(50, 25);
 
-    this._constructorsDataGrid = new WebInspector.HeapSnapshotConstructorsDataGrid();
+    this._constructorsDataGrid = new WebInspector.HeapSnapshotConstructorsDataGrid(panel);
     this._constructorsDataGrid.show(this._constructorsView.element);
     this._constructorsDataGrid.addEventListener(WebInspector.DataGrid.Events.SelectedNode, this._selectionChanged, this);
 
     this._diffView = new WebInspector.VBox();
     this._diffView.setMinimumSize(50, 25);
 
-    this._diffDataGrid = new WebInspector.HeapSnapshotDiffDataGrid();
+    this._diffDataGrid = new WebInspector.HeapSnapshotDiffDataGrid(panel);
     this._diffDataGrid.show(this._diffView.element);
     this._diffDataGrid.addEventListener(WebInspector.DataGrid.Events.SelectedNode, this._selectionChanged, this);
 
     this._dominatorView = new WebInspector.VBox();
     this._dominatorView.setMinimumSize(50, 25);
-    this._dominatorDataGrid = new WebInspector.HeapSnapshotDominatorsDataGrid();
+    this._dominatorDataGrid = new WebInspector.HeapSnapshotDominatorsDataGrid(panel);
     this._dominatorDataGrid.show(this._dominatorView.element);
     this._dominatorDataGrid.addEventListener(WebInspector.DataGrid.Events.SelectedNode, this._selectionChanged, this);
 
     if (WebInspector.experimentsSettings.allocationProfiler.isEnabled() && profile.profileType() === WebInspector.ProfileTypeRegistry.instance.trackingHeapSnapshotProfileType) {
         this._allocationView = new WebInspector.VBox();
         this._allocationView.setMinimumSize(50, 25);
-        this._allocationDataGrid = new WebInspector.AllocationDataGrid();
+        this._allocationDataGrid = new WebInspector.AllocationDataGrid(panel);
         this._allocationDataGrid.addEventListener(WebInspector.DataGrid.Events.SelectedNode, this._onSelectAllocationNode, this);
         this._allocationDataGrid.show(this._allocationView.element);
 
         this._allocationStackView = new WebInspector.HeapAllocationStackView();
         this._allocationStackView.setMinimumSize(50, 25);
 
         this._tabbedPane = new WebInspector.TabbedPane();
         this._tabbedPane.closeableTabs = false;
         this._tabbedPane.headerElement().classList.add("heap-object-details-header");
     }
@@ skipping 19 matching lines @@
         var retainingPathsTitle = retainingPathsTitleDiv.createChild("span");
         retainingPathsTitle.textContent = WebInspector.UIString("Retainers");
         this._retainmentView.element.appendChild(retainmentViewHeader);
 
         splitViewResizer = retainmentViewHeader;
         this._objectDetailsView = this._retainmentView;
     }
     this._splitView.hideDefaultResizer();
     this._splitView.installResizer(splitViewResizer);
 
-    this._retainmentDataGrid = new WebInspector.HeapSnapshotRetainmentDataGrid();
+    this._retainmentDataGrid = new WebInspector.HeapSnapshotRetainmentDataGrid(panel);
     this._retainmentDataGrid.show(this._retainmentView.element);
     this._retainmentDataGrid.addEventListener(WebInspector.DataGrid.Events.SelectedNode, this._inspectedObjectChanged, this);
     this._retainmentDataGrid.reset();
 
     this._perspectives = [];
     this._perspectives.push(new WebInspector.HeapSnapshotView.SummaryPerspective());
     if (profile.profileType() !== WebInspector.ProfileTypeRegistry.instance.trackingHeapSnapshotProfileType)
         this._perspectives.push(new WebInspector.HeapSnapshotView.ComparisonPerspective());
     this._perspectives.push(new WebInspector.HeapSnapshotView.ContainmentPerspective());
     if (WebInspector.settings.showAdvancedHeapSnapshotProperties.get())
@@ skipping 1083 matching lines @@
         /**
          * @param {?string} error
          * @this {WebInspector.HeapSnapshotProfileType}
          */
         function didTakeHeapSnapshot(error)
         {
             var profile = this._profileBeingRecorded;
             profile.title = WebInspector.UIString("Snapshot %d", profile.uid);
             profile._finishLoad();
             this._profileBeingRecorded = null;
-            WebInspector.panels.profiles.showProfile(profile);
+            WebInspector.Revealer.reveal(profile);

[yurys, 2014/05/07 14:43:41]

We could implement this as an event on corresponding profile type, the panel
could listen to that event and reveal the profile when it is complete.

[apavlov, 2014/05/07 15:54:23]

Done.

             callback();
         }
         HeapProfilerAgent.takeHeapSnapshot(true, didTakeHeapSnapshot.bind(this));
     },
 
     /**
      * @override
      * @param {string} chunk
      */
     addHeapSnapshotChunk: function(chunk)
@@ skipping 168 matching lines @@
         function didTakeHeapSnapshot(error)
         {
             var target = /** @type {!WebInspector.Target} */ (WebInspector.targetManager.activeTarget());
             target.profilingLock.release();
             var profile = this._profileBeingRecorded;
             if (!profile)
                 return;
             profile._finishLoad();
             this._profileSamples = null;
             this._profileBeingRecorded = null;
-            WebInspector.panels.profiles.showProfile(profile);
+            WebInspector.Revealer.reveal(profile);
         }
 
         HeapProfilerAgent.stopTrackingHeapObjects(true, didTakeHeapSnapshot.bind(this));
         this._recording = false;
         this.dispatchEventToListeners(WebInspector.TrackingHeapSnapshotProfileType.TrackingStopped);
     },
 
     _toggleRecording: function()
     {
         if (this._recording)
@@ skipping 76 matching lines @@
      * @override
      * @return {!WebInspector.ProfileSidebarTreeElement}
      */
     createSidebarTreeElement: function()
     {
         return new WebInspector.ProfileSidebarTreeElement(this, "heap-snapshot-sidebar-tree-item");
     },
 
     /**
      * @override
+     * @param {!WebInspector.ProfilesPanel} panel
      * @return {!WebInspector.HeapSnapshotView}
      */
-    createView: function()
+    createView: function(panel)
     {
-        return new WebInspector.HeapSnapshotView(this);
+        return new WebInspector.HeapSnapshotView(panel, this);
     },
 
     /**
      * @override
      * @param {function(!WebInspector.HeapSnapshotProxy):void} callback
      */
     load: function(callback)
     {
         if (this.uid === -1)
             return;
@@ skipping 741 matching lines @@
                     urlElement = this._linkifier.linkifyRawLocation(rawLocation);
                 if (!urlElement)
                     urlElement = this._linkifier.linkifyLocation(this._target, frame.scriptName, frame.line - 1, frame.column - 1);
                 frameDiv.appendChild(urlElement);
             }
         }
     },
 
     __proto__: WebInspector.View.prototype
 }