DevTools: Get rid of WebInspector.panels

Source/devtools/front_end/profiler/ProfilesPanel.js

 /*
  * Copyright (C) 2008 Apple Inc. All Rights Reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 25 matching lines @@
     this._name = name;
     /** @type {!Array.<!WebInspector.ProfileHeader>} */
     this._profiles = [];
     /** @type {?WebInspector.ProfileHeader} */
     this._profileBeingRecorded = null;
     this._nextProfileUid = 1;
 
     window.addEventListener("unload", this._clearTempStorage.bind(this), false);
 }
 
+/**
+ * @enum {string}
+ */
 WebInspector.ProfileType.Events = {
     AddProfileHeader: "add-profile-header",
+    ProfileComplete: "profile-complete",
     RemoveProfileHeader: "remove-profile-header",
     ViewUpdated: "view-updated"
 }
 
 WebInspector.ProfileType.prototype = {
     /**
      * @return {boolean}
      */
     hasTemporaryView: function()
     {
@@ skipping 198 matching lines @@
         if (this._profileBeingRecorded === profile) {
             this.profileBeingRecordedRemoved();
             this.setProfileBeingRecorded(null);
         }
     },
 
     __proto__: WebInspector.Object.prototype
 }
 
 /**
+ * @interface
+ */
+WebInspector.ProfileType.DataDisplayDelegate = function()
+{
+}
+
+WebInspector.ProfileType.DataDisplayDelegate.prototype = {
+    /**
+     * @param {?WebInspector.ProfileHeader} profile
+     * @return {?WebInspector.View}
+     */
+    showProfile: function(profile) { },
+
+    /**
+     * @param {!HeapProfilerAgent.HeapSnapshotObjectId} snapshotObjectId
+     * @param {string} perspectiveName
+     */
+    showObject: function(snapshotObjectId, perspectiveName) { }
+}
+
+/**
  * @constructor
  * @extends {WebInspector.TargetAwareObject}
  * @param {!WebInspector.ProfileType} profileType
  * @param {string} title
  */
 WebInspector.ProfileHeader = function(target, profileType, title)
 {
     WebInspector.TargetAwareObject.call(this, target);
     this._profileType = profileType;
     this.title = title;
@@ skipping 32 matching lines @@
      * @param {?string} subtitle
      * @param {boolean=} wait
      */
     updateStatus: function(subtitle, wait)
     {
         this.dispatchEventToListeners(WebInspector.ProfileHeader.Events.UpdateStatus, new WebInspector.ProfileHeader.StatusUpdate(subtitle, wait));
     },
 
     /**
      * Must be implemented by subclasses.
+     * @param {!WebInspector.ProfileType.DataDisplayDelegate} dataDisplayDelegate
      * @return {!WebInspector.ProfileSidebarTreeElement}
      */
-    createSidebarTreeElement: function()
+    createSidebarTreeElement: function(dataDisplayDelegate)
     {
         throw new Error("Needs implemented.");
     },
 
     /**
+     * @param {!WebInspector.ProfileType.DataDisplayDelegate} dataDisplayDelegate
      * @return {!WebInspector.View}
      */
-    createView: function()
+    createView: function(dataDisplayDelegate)
     {
         throw new Error("Not implemented.");
     },
 
     removeTempFile: function()
     {
         if (this._tempFile)
             this._tempFile.remove();
     },
 
@@ skipping 41 matching lines @@
     {
         this._fromFile = true;
     },
 
     __proto__: WebInspector.TargetAwareObject.prototype
 }
 
 /**
  * @constructor
  * @implements {WebInspector.Searchable}
+ * @implements {WebInspector.ProfileType.DataDisplayDelegate}
  * @extends {WebInspector.PanelWithSidebarTree}
  */
 WebInspector.ProfilesPanel = function()
 {
     WebInspector.PanelWithSidebarTree.call(this, "profiles");
     this.registerRequiredCSS("panelEnablerView.css");
     this.registerRequiredCSS("heapProfiler.css");
     this.registerRequiredCSS("profilesPanel.css");
 
     this._target = /** @type {!WebInspector.Target} */ (WebInspector.targetManager.activeTarget());
@@ skipping 281 matching lines @@
     {
         HeapProfilerAgent.collectGarbage();
     },
 
     /**
      * @param {!WebInspector.ProfileType} profileType
      */
     _registerProfileType: function(profileType)
     {
         this._launcherView.addProfileType(profileType);
-        var profileTypeSection = new WebInspector.ProfileTypeSidebarSection(profileType);
+        var profileTypeSection = new WebInspector.ProfileTypeSidebarSection(this, profileType);
         this._typeIdToSidebarSection[profileType.id] = profileTypeSection
         this.sidebarTree.appendChild(profileTypeSection);
         profileTypeSection.childrenListElement.addEventListener("contextmenu", this._handleContextMenuEvent.bind(this), true);
 
         /**
+         * @param {!WebInspector.Event} event
          * @this {WebInspector.ProfilesPanel}
          */
         function onAddProfileHeader(event)
         {
-            this._addProfileHeader(event.data);
+            this._addProfileHeader(/** @type {!WebInspector.ProfileHeader} */ (event.data));
         }
 
         /**
+         * @param {!WebInspector.Event} event
          * @this {WebInspector.ProfilesPanel}
          */
         function onRemoveProfileHeader(event)
         {
-            this._removeProfileHeader(event.data);
+            this._removeProfileHeader(/** @type {!WebInspector.ProfileHeader} */ (event.data));
+        }
+
+        /**
+         * @param {!WebInspector.Event} event
+         * @this {WebInspector.ProfilesPanel}
+         */
+        function profileComplete(event)
+        {
+            this.showProfile(/** @type {!WebInspector.ProfileHeader} */ (event.data));
         }
 
         profileType.addEventListener(WebInspector.ProfileType.Events.ViewUpdated, this._updateProfileTypeSpecificUI, this);
         profileType.addEventListener(WebInspector.ProfileType.Events.AddProfileHeader, onAddProfileHeader, this);
         profileType.addEventListener(WebInspector.ProfileType.Events.RemoveProfileHeader, onRemoveProfileHeader, this);
+        profileType.addEventListener(WebInspector.ProfileType.Events.ProfileComplete, profileComplete, this);
 
         var profiles = profileType.getProfiles();
         for (var i = 0; i < profiles.length; i++)
             this._addProfileHeader(profiles[i]);
     },
 
     /**
      * @param {?Event} event
      */
     _handleContextMenuEvent: function(event)
@@ skipping 113 matching lines @@
 
     /**
      * @param {!WebInspector.ProfileHeader} profile
      * @return {!WebInspector.View}
      */
     _viewForProfile: function(profile)
     {
         var index = this._indexOfViewForProfile(profile);
         if (index !== -1)
             return this._profileToView[index].view;
-        var view = profile.createView();
+        var view = profile.createView(this);
         view.element.classList.add("profile-view");
         this._profileToView.push({ profile: profile, view: view});
         return view;
     },
 
     /**
      * @param {!WebInspector.ProfileHeader} profile
      * @return {number}
      */
     _indexOfViewForProfile: function(profile)
@@ skipping 123 matching lines @@
         contextMenu.appendItem(WebInspector.UIString(WebInspector.useLowerCaseMenuTitles() ? "Reveal in Summary view" : "Reveal in Summary View"), revealInView.bind(this, "Summary"));
     },
 
     __proto__: WebInspector.PanelWithSidebarTree.prototype
 }
 
 
 /**
  * @constructor
  * @extends {WebInspector.SidebarSectionTreeElement}
+ * @param {!WebInspector.ProfileType.DataDisplayDelegate} dataDisplayDelegate
  * @param {!WebInspector.ProfileType} profileType
  */
-WebInspector.ProfileTypeSidebarSection = function(profileType)
+WebInspector.ProfileTypeSidebarSection = function(dataDisplayDelegate, profileType)
 {
     WebInspector.SidebarSectionTreeElement.call(this, profileType.treeItemTitle, null, true);
+    this._dataDisplayDelegate = dataDisplayDelegate;
     this._profileTreeElements = [];
     this._profileGroups = {};
     this.hidden = true;
 }
 
 /**
  * @constructor
  */
 WebInspector.ProfileTypeSidebarSection.ProfileGroup = function()
 {
     this.profileSidebarTreeElements = [];
     this.sidebarTreeElement = null;
 }
 
 WebInspector.ProfileTypeSidebarSection.prototype = {
     /**
      * @param {!WebInspector.ProfileHeader} profile
      */
     addProfileHeader: function(profile)
     {
         this.hidden = false;
         var profileType = profile.profileType();
         var sidebarParent = this;
-        var profileTreeElement = profile.createSidebarTreeElement();
+        var profileTreeElement = profile.createSidebarTreeElement(this._dataDisplayDelegate);
         this._profileTreeElements.push(profileTreeElement);
 
         if (!profile.fromFile() && profileType.profileBeingRecorded() !== profile) {
             var profileTitle = profile.title;
             var group = this._profileGroups[profileTitle];
             if (!group) {
                 group = new WebInspector.ProfileTypeSidebarSection.ProfileGroup();
                 this._profileGroups[profileTitle] = group;
             }
             group.profileSidebarTreeElements.push(profileTreeElement);
 
             var groupSize = group.profileSidebarTreeElements.length;
             if (groupSize === 2) {
                 // Make a group TreeElement now that there are 2 profiles.
-                group.sidebarTreeElement = new WebInspector.ProfileGroupSidebarTreeElement(profile.title);
+                group.sidebarTreeElement = new WebInspector.ProfileGroupSidebarTreeElement(this._dataDisplayDelegate, profile.title);
 
                 var firstProfileTreeElement = group.profileSidebarTreeElements[0];
                 // Insert at the same index for the first profile of the group.
                 var index = this.children.indexOf(firstProfileTreeElement);
                 this.insertChild(group.sidebarTreeElement, index);
 
                 // Move the first profile to the group.
                 var selected = firstProfileTreeElement.selected;
                 this.removeChild(firstProfileTreeElement);
                 group.sidebarTreeElement.appendChild(firstProfileTreeElement);
@@ skipping 96 matching lines @@
      */
     appendApplicableItems: function(event, contextMenu, target)
     {
         WebInspector.inspectorView.panel("profiles").appendApplicableItems(event, contextMenu, target);
     }
 }
 
 /**
  * @constructor
  * @extends {WebInspector.SidebarTreeElement}
+ * @param {!WebInspector.ProfileType.DataDisplayDelegate} dataDisplayDelegate
  * @param {!WebInspector.ProfileHeader} profile
  * @param {string} className
  */
-WebInspector.ProfileSidebarTreeElement = function(profile, className)
+WebInspector.ProfileSidebarTreeElement = function(dataDisplayDelegate, profile, className)
 {
+    this._dataDisplayDelegate = dataDisplayDelegate;
     this.profile = profile;
     WebInspector.SidebarTreeElement.call(this, className, profile.title, "", profile, false);
     this.refreshTitles();
     profile.addEventListener(WebInspector.ProfileHeader.Events.UpdateStatus, this._updateStatus, this);
     if (profile.canSaveToFile())
         this._createSaveLink();
     else
         profile.addEventListener(WebInspector.ProfileHeader.Events.ProfileReceived, this._onProfileReceived, this);
 }
 
@@ skipping 24 matching lines @@
     },
 
     dispose: function()
     {
         this.profile.removeEventListener(WebInspector.ProfileHeader.Events.UpdateStatus, this._updateStatus, this);
         this.profile.removeEventListener(WebInspector.ProfileHeader.Events.ProfileReceived, this._onProfileReceived, this);
     },
 
     onselect: function()
     {
-        WebInspector.panels.profiles.showProfile(this.profile);
+        this._dataDisplayDelegate.showProfile(this.profile);
     },
 
     /**
      * @return {boolean}
      */
     ondelete: function()
     {
         this.profile.profileType().removeProfile(this.profile);
         return true;
     },
@@ skipping 18 matching lines @@
     {
         this.profile.saveToFile();
     },
 
     __proto__: WebInspector.SidebarTreeElement.prototype
 }
 
 /**
  * @constructor
  * @extends {WebInspector.SidebarTreeElement}
+ * @param {!WebInspector.ProfileType.DataDisplayDelegate} dataDisplayDelegate
  * @param {string} title
  * @param {string=} subtitle
  */
-WebInspector.ProfileGroupSidebarTreeElement = function(title, subtitle)
+WebInspector.ProfileGroupSidebarTreeElement = function(dataDisplayDelegate, title, subtitle)
 {
     WebInspector.SidebarTreeElement.call(this, "profile-group-sidebar-tree-item", title, subtitle, null, true);
+    this._dataDisplayDelegate = dataDisplayDelegate;
 }
 
 WebInspector.ProfileGroupSidebarTreeElement.prototype = {
     onselect: function()
     {
         if (this.children.length > 0)
-            WebInspector.panels.profiles.showProfile(this.children[this.children.length - 1].profile);
+            this._dataDisplayDelegate.showProfile(this.children[this.children.length - 1].profile);
     },
 
     __proto__: WebInspector.SidebarTreeElement.prototype
 }
 
 /**
  * @constructor
  * @extends {WebInspector.SidebarTreeElement}
  * @param {!WebInspector.ProfilesPanel} panel
  */
@@ skipping 29 matching lines @@
 importScript("HeapSnapshotCommon.js");
 importScript("HeapSnapshotProxy.js");
 importScript("HeapSnapshotDataGrids.js");
 importScript("HeapSnapshotGridNodes.js");
 importScript("HeapSnapshotView.js");
 importScript("ProfileLauncherView.js");
 importScript("CanvasProfileView.js");
 importScript("CanvasReplayStateView.js");
 
 WebInspector.ProfileTypeRegistry.instance = new WebInspector.ProfileTypeRegistry();