DevTools: Get rid of WebInspector.panels

Source/devtools/front_end/ui/InspectorView.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 30 matching lines @@
     // DevTools sidebar is a vertical split of panels tabbed pane and a drawer.
     this._drawerSplitView = new WebInspector.SplitView(false, true, "Inspector.drawerSplitViewState", 200, 200);
     this._drawerSplitView.hideSidebar();
     this._drawerSplitView.enableShowModeSaving();
     this._drawerSplitView.show(this.element);
 
     this._tabbedPane = new WebInspector.TabbedPane();
     this._tabbedPane.setRetainTabOrder(true, WebInspector.moduleManager.orderComparator(WebInspector.Panel, "name", "order"));
     this._tabbedPane.show(this._drawerSplitView.mainElement());
     this._drawer = new WebInspector.Drawer(this._drawerSplitView);
+    this._panels = {};
 
     // Patch tabbed pane header with toolbar actions.
     this._toolbarElement = document.createElement("div");
     this._toolbarElement.className = "toolbar toolbar-background";
     var headerElement = this._tabbedPane.headerElement();
     headerElement.parentElement.insertBefore(this._toolbarElement, headerElement);
 
     this._leftToolbarElement = this._toolbarElement.createChild("div", "toolbar-controls-left");
     this._toolbarElement.appendChild(headerElement);
     this._rightToolbarElement = this._toolbarElement.createChild("div", "toolbar-controls-right");
@@ skipping 61 matching lines @@
     {
         var panelName = panelDescriptor.name();
         this._panelDescriptors[panelName] = panelDescriptor;
         this._tabbedPane.appendTab(panelName, panelDescriptor.title(), new WebInspector.View());
         if (this._lastActivePanelSetting.get() === panelName)
             this._tabbedPane.selectTab(panelName);
     },
 
     /**
      * @param {string} panelName
+     * @param {boolean=} skipFallback
      * @return {?WebInspector.Panel}
      */
-    panel: function(panelName)
+    panel: function(panelName, skipFallback)

[pfeldman, 2014/05/06 19:57:14]

Either change the naming scheme or make it pure accessor. skipFallback semantics
is also unclear. Should it always be "true"?

[apavlov, 2014/05/07 10:26:13]

I don't know. AFAIU, the case behind the fallback is restoring an
extension-provided panel when the extension has been disabled. Perhaps, we
should explicitly have the "defaultPanel()" accessor or something.

     {
+        if (this._panels[panelName])
+            return this._panels[panelName];
         var panelDescriptor = this._panelDescriptors[panelName];
         var panelOrder = this._tabbedPane.allTabs();
-        if (!panelDescriptor && panelOrder.length)
+        if (!skipFallback && !panelDescriptor && panelOrder.length)
             panelDescriptor = this._panelDescriptors[panelOrder[0]];
-        return panelDescriptor ? panelDescriptor.panel() : null;
+        var panel = panelDescriptor ? panelDescriptor.panel() : null;
+        if (!this._panels[panelName])
+            this._panels[panelName] = panel;
+        return panel;
     },
 
     /**
      * @param {string} panelName
      * @return {?WebInspector.Panel}
      */
     showPanel: function(panelName)
     {
         var panel = this.panel(panelName);
         if (panel)
@@ skipping 210 matching lines @@
 
     _moveInHistory: function(move)
     {
         var newIndex = this._historyIterator + move;
         if (newIndex >= this._history.length || newIndex < 0)
             return false;
 
         this._inHistory = true;
         this._historyIterator = newIndex;
         if (!WebInspector.Dialog.currentInstance())
-            this.setCurrentPanel(WebInspector.panels[this._history[this._historyIterator]]);
+            this.setCurrentPanel(this._panels[this._history[this._historyIterator]]);
         delete this._inHistory;
 
         return true;
     },
 
     _pushToHistory: function(panelName)
     {
         if (this._inHistory)
             return;
 
@@ skipping 123 matching lines @@
             window.addEventListener("scroll", this._onScrollBound, false);
         else
             window.removeEventListener("scroll", this._onScrollBound, false);
 
         WebInspector.VBox.prototype.doResize.call(this);
         this._onScroll();
     },
 
     __proto__: WebInspector.VBox.prototype
 };