Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Side by Side Diff: Source/devtools/front_end/profiler/CPUProfileView.js

Issue 268293003: DevTools: Get rid of WebInspector.panels (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 628 matching lines...) Expand 10 before | Expand all | Expand 10 after
639 function didStopProfiling(error, profile) 639 function didStopProfiling(error, profile)
640 { 640 {
641 var target = /** @type {!WebInspector.Target} */ (WebInspector.targe tManager.activeTarget()); 641 var target = /** @type {!WebInspector.Target} */ (WebInspector.targe tManager.activeTarget());
642 target.profilingLock.release(); 642 target.profilingLock.release();
643 if (!this._profileBeingRecorded) 643 if (!this._profileBeingRecorded)
644 return; 644 return;
645 this._profileBeingRecorded.setProtocolProfile(profile); 645 this._profileBeingRecorded.setProtocolProfile(profile);
646 this._profileBeingRecorded.updateStatus(""); 646 this._profileBeingRecorded.updateStatus("");
647 var recordedProfile = this._profileBeingRecorded; 647 var recordedProfile = this._profileBeingRecorded;
648 this._profileBeingRecorded = null; 648 this._profileBeingRecorded = null;
649 WebInspector.panels.profiles.showProfile(recordedProfile); 649 WebInspector.inspectorView.panel("profiles").showProfile(recordedPro file);
pfeldman 2014/05/06 19:57:14 How does this compile? Getting rid of global acces
apavlov 2014/05/07 10:26:13 It's no different from accessing fields of WebInsp
650 } 650 }
651 ProfilerAgent.stop(didStopProfiling.bind(this)); 651 ProfilerAgent.stop(didStopProfiling.bind(this));
652 }, 652 },
653 653
654 /** 654 /**
655 * @override 655 * @override
656 * @param {string} title 656 * @param {string} title
657 * @return {!WebInspector.ProfileHeader} 657 * @return {!WebInspector.ProfileHeader}
658 */ 658 */
659 createProfileLoadedFromFile: function(title) 659 createProfileLoadedFromFile: function(title)
(...skipping 229 matching lines...) Expand 10 before | Expand all | Expand 10 after
889 _notifyTempFileReady: function() 889 _notifyTempFileReady: function()
890 { 890 {
891 if (this._onTempFileReady) { 891 if (this._onTempFileReady) {
892 this._onTempFileReady(); 892 this._onTempFileReady();
893 this._onTempFileReady = null; 893 this._onTempFileReady = null;
894 } 894 }
895 }, 895 },
896 896
897 __proto__: WebInspector.ProfileHeader.prototype 897 __proto__: WebInspector.ProfileHeader.prototype
898 } 898 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698