DevTools: Get rid of WebInspector.panels

LayoutTests/http/tests/inspector/appcache/appcache-test.js

 var framesCount = 0;
 
 function createAndNavigateIFrame(url)
 {
     var iframe = document.createElement("iframe");
     iframe.src = url;
     iframe.name = "frame" + ++framesCount;
     iframe.id = iframe.name;
     document.body.appendChild(iframe);
 }
@@ skipping 63 matching lines @@
 InspectorTest.dumpApplicationCache = function()
 {
     InspectorTest.dumpApplicationCacheTree();
     InspectorTest.dumpApplicationCacheModel();
     InspectorTest.addResult("");
 }
 
 InspectorTest.dumpApplicationCacheTree = function()
 {
     InspectorTest.addResult("Dumping application cache tree:");
-    var applicationCacheTreeElement = WebInspector.panels.resources.applicationCacheListTreeElement;
+    var applicationCacheTreeElement = WebInspector.inspectorView.panel("resources").applicationCacheListTreeElement;

[pfeldman, 2014/05/06 19:57:14]

I don't see how this is better. Lets keep it as is in tests?

[apavlov, 2014/05/07 10:26:13]

There doesn't seem to be any point in keeping WebInspector.panels and "just"
forbidding the access in ordinary code. Can we change this to
WebInspector.inspectorView._panels instead?

     if (!applicationCacheTreeElement.children.length) {
         InspectorTest.addResult("    (empty)");
         return;
     }
     for (var i = 0; i < applicationCacheTreeElement.children.length; ++i) {
         var manifestTreeElement = applicationCacheTreeElement.children[i];
         InspectorTest.addResult("    Manifest URL: " + manifestTreeElement.manifestURL);
         if (!manifestTreeElement.children.length) {
             InspectorTest.addResult("    (no frames)");
             continue;
@@ skipping 25 matching lines @@
     statusInformation[applicationCache.CHECKING]    = "CHECKING";
     statusInformation[applicationCache.DOWNLOADING] = "DOWNLOADING";
     statusInformation[applicationCache.UPDATEREADY] = "UPDATEREADY";
     statusInformation[applicationCache.OBSOLETE]    = "OBSOLETE";
     return statusInformation[status] || statusInformation[applicationCache.UNCACHED];
 }
 
 InspectorTest.dumpApplicationCacheModel = function()
 {
     InspectorTest.addResult("Dumping application cache model:");
-    var model = WebInspector.panels.resources._applicationCacheModel;
+    var model = WebInspector.inspectorView.panel("resources")._applicationCacheModel;
 
     var frameIds = [];
     for (var frameId in model._manifestURLsByFrame)
         frameIds.push(frameId);
 
     function compareFunc(a, b) {
         return InspectorTest.frameIdToString(a).localeCompare(InspectorTest.frameIdToString(b));
     }
     frameIds.sort(compareFunc);
 
     if (!frameIds.length) {
         InspectorTest.addResult("    (empty)");
         return;
     }
     for (var i = 0; i < frameIds.length; ++i) {
         var frameId = frameIds[i];
         var manifestURL = model.frameManifestURL(frameId);
         var status = model.frameManifestStatus(frameId);
         InspectorTest.addResult("    Frame: " + InspectorTest.frameIdToString(frameId));
         InspectorTest.addResult("        manifest url: " + manifestURL);
         InspectorTest.addResult("        status:       " + InspectorTest.applicationCacheStatusToString(status));
     }
 }
 
 InspectorTest.waitForFrameManifestURLAndStatus = function(frameId, manifestURL, status, callback)
 {
-    var frameManifestStatus = WebInspector.panels.resources._applicationCacheModel.frameManifestStatus(frameId);
-    var frameManifestURL = WebInspector.panels.resources._applicationCacheModel.frameManifestURL(frameId);
+    var frameManifestStatus = WebInspector.inspectorView.panel("resources")._applicationCacheModel.frameManifestStatus(frameId);
+    var frameManifestURL = WebInspector.inspectorView.panel("resources")._applicationCacheModel.frameManifestURL(frameId);
     if (frameManifestStatus === status && frameManifestURL.indexOf(manifestURL) !== -1) {
         callback();
         return;
     }
 
     var handler = InspectorTest.waitForFrameManifestURLAndStatus.bind(this, frameId, manifestURL, status, callback);
     InspectorTest.addSniffer(WebInspector.ApplicationCacheModel.prototype, "_frameManifestUpdated", handler);
 }
 
 InspectorTest.startApplicationCacheStatusesRecording = function()
@@ skipping 32 matching lines @@
         return;
     }
 
     if (!InspectorTest.awaitedFrameStatusEventsCount)
         InspectorTest.awaitedFrameStatusEventsCount = {};
     InspectorTest.awaitedFrameStatusEventsCount[frameId] = { count: eventsLeft, callback: callback };
 }
 
 };