Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 268293002: Revert of Start session fail causes restart chrome (Closed)

Created:
6 years, 7 months ago by Nikita (slow)
Modified:
6 years, 7 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of Start session fail causes restart chrome (https://codereview.chromium.org/228703004/) Reason for revert: Seems to be breaking user sign in. See also http://crbug.com/369040 Original issue's description: > Start session fail causes restart chrome > > BUG=244628 > TEST=manual check on Acer C720 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266791 NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268511

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -123 lines) Patch
M chrome/browser/chromeos/login/crash_restore_browsertest.cc View 3 chunks +4 lines, -34 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils.cc View 2 chunks +4 lines, -49 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_test_helper.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_test_helper.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chromeos/dbus/fake_session_manager_client.h View 1 chunk +1 line, -2 lines 0 comments Download
M chromeos/dbus/fake_session_manager_client.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chromeos/dbus/mock_session_manager_client.h View 1 chunk +1 line, -2 lines 0 comments Download
M chromeos/dbus/session_manager_client.h View 1 chunk +1 line, -6 lines 0 comments Download
M chromeos/dbus/session_manager_client.cc View 4 chunks +7 lines, -20 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Nikita (slow)
Created Revert of Start session fail causes restart chrome
6 years, 7 months ago (2014-05-06 12:51:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/268293002/1
6 years, 7 months ago (2014-05-06 12:51:48 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-06 12:51:49 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 7 months ago (2014-05-06 12:51:50 UTC) #4
Nikita (slow)
lgtm
6 years, 7 months ago (2014-05-06 13:15:50 UTC) #5
Nikita (slow)
The CQ bit was checked by nkostylev@chromium.org
6 years, 7 months ago (2014-05-06 13:15:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/268293002/1
6 years, 7 months ago (2014-05-06 13:16:06 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-06 13:16:07 UTC) #8
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 7 months ago (2014-05-06 13:16:08 UTC) #9
Denis Kuznetsov (DE-MUC)
lgtm lgtm
6 years, 7 months ago (2014-05-06 13:38:02 UTC) #10
Nikita (slow)
The CQ bit was unchecked by nkostylev@chromium.org
6 years, 7 months ago (2014-05-06 14:02:57 UTC) #11
Nikita (slow)
The CQ bit was checked by nkostylev@chromium.org
6 years, 7 months ago (2014-05-06 14:02:58 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/268293002/1
6 years, 7 months ago (2014-05-06 14:03:43 UTC) #13
commit-bot: I haz the power
6 years, 7 months ago (2014-05-06 14:04:50 UTC) #14
Message was sent while issue was closed.
Change committed as 268511

Powered by Google App Engine
This is Rietveld 408576698