Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Unified Diff: components/minidump_uploader/android/javatests/src/org/chromium/components/minidump_uploader/MinidumpUploadCallableTest.java

Issue 2682913006: [Android WebView] Always schedule new upload job after copying minidump. (Closed)
Patch Set: Added inline comments explaining the new (non-)cancellation behaviour. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/crash/MinidumpUploaderTest.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/minidump_uploader/android/javatests/src/org/chromium/components/minidump_uploader/MinidumpUploadCallableTest.java
diff --git a/components/minidump_uploader/android/javatests/src/org/chromium/components/minidump_uploader/MinidumpUploadCallableTest.java b/components/minidump_uploader/android/javatests/src/org/chromium/components/minidump_uploader/MinidumpUploadCallableTest.java
index a8f0f815238ff2e2170adef53900d523e2e46107..c512b24579f410ba1e37e52a5a511fa3ea3868e3 100644
--- a/components/minidump_uploader/android/javatests/src/org/chromium/components/minidump_uploader/MinidumpUploadCallableTest.java
+++ b/components/minidump_uploader/android/javatests/src/org/chromium/components/minidump_uploader/MinidumpUploadCallableTest.java
@@ -35,7 +35,11 @@ public class MinidumpUploadCallableTest extends CrashTestCase {
private File mUploadLog;
private File mExpectedFileAfterUpload;
- private static class TestHttpURLConnection extends HttpURLConnection {
+ /**
+ * A HttpURLConnection that performs some basic checks to ensure we are uploading
+ * minidumps correctly.
+ */
+ public static class TestHttpURLConnection extends HttpURLConnection {
private static final String EXPECTED_CONTENT_TYPE_VALUE =
String.format(MinidumpUploadCallable.CONTENT_TYPE_TMPL, BOUNDARY);
@@ -44,7 +48,7 @@ public class MinidumpUploadCallableTest extends CrashTestCase {
*/
private String mContentTypePropertyValue = "";
- TestHttpURLConnection(URL url) {
+ public TestHttpURLConnection(URL url) {
super(url);
assertEquals(MinidumpUploadCallable.CRASH_URL_STRING, url.toString());
}
@@ -61,7 +65,7 @@ public class MinidumpUploadCallableTest extends CrashTestCase {
}
@Override
- public OutputStream getOutputStream() {
+ public OutputStream getOutputStream() throws IOException {
return new ByteArrayOutputStream();
}
« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/crash/MinidumpUploaderTest.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698