Index: android_webview/java/src/org/chromium/android_webview/crash/MinidumpUploaderImpl.java |
diff --git a/android_webview/java/src/org/chromium/android_webview/crash/MinidumpUploaderImpl.java b/android_webview/java/src/org/chromium/android_webview/crash/MinidumpUploaderImpl.java |
index e47cd268f52bc70c5c023fe977276f05c720cb52..2c762816537c75c069d7d720e04d2f780ca0b4f3 100644 |
--- a/android_webview/java/src/org/chromium/android_webview/crash/MinidumpUploaderImpl.java |
+++ b/android_webview/java/src/org/chromium/android_webview/crash/MinidumpUploaderImpl.java |
@@ -202,14 +202,18 @@ public class MinidumpUploaderImpl implements MinidumpUploader { |
ThreadUtils.assertOnUiThread(); |
mPermittedByUser = enabled; |
- // Our job might have been cancelled by now - make sure we honour this. |
- if (!getCancelUpload()) { |
- mWorkerThread.start(); |
- } |
+ // Start our job even if it might have been cancelled already - we want to try to |
+ // make some progress whenever we start a job. |
Ilya Sherman
2017/02/11 01:00:47
This is a bit unclear to me -- are we simply ignor
gsennton
2017/02/13 10:46:55
We are indeed ignoring the initial cancellation he
Ilya Sherman
2017/02/13 22:28:15
Could we simply swap steps 5 and 6, thereby gettin
gsennton
2017/02/14 16:49:41
So the deal is this:
When you schedule a new JobSc
Ilya Sherman
2017/02/15 00:21:05
Okay, I see, I think I understand. I think it wou
gsennton
2017/02/15 10:26:58
Done (ptal).
|
+ mWorkerThread.start(); |
} |
}); |
} |
+ @VisibleForTesting |
+ public void joinWorkerThreadForTesting() throws InterruptedException { |
+ mWorkerThread.join(); |
+ } |
+ |
/** |
* @return whether to reschedule the uploads. |
*/ |