Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7148)

Unified Diff: chrome/test/data/webui/settings/languages_page_browsertest.js

Issue 2682893002: MD Settings: Removing invalid selectors from language page tests. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webui/settings/languages_page_browsertest.js
diff --git a/chrome/test/data/webui/settings/languages_page_browsertest.js b/chrome/test/data/webui/settings/languages_page_browsertest.js
index ed8935a0f6c6b4a582189a454268899651ea3308..81dc4e53acbb541b46f562942e339d2d331e9ba6 100644
--- a/chrome/test/data/webui/settings/languages_page_browsertest.js
+++ b/chrome/test/data/webui/settings/languages_page_browsertest.js
@@ -116,7 +116,7 @@ TEST_F('SettingsLanguagesPageBrowserTest', 'MAYBE_LanguagesPage', function() {
setup(function(done) {
var addLanguagesButton =
- languagesCollapse.querySelector('.list-button:last-of-type');
+ languagesCollapse.querySelector('#addLanguagesButton');
MockInteractions.tap(addLanguagesButton);
// The page stamps the dialog, registers listeners, and populates the
@@ -412,7 +412,7 @@ TEST_F('SettingsLanguagesPageBrowserTest', 'MAYBE_LanguagesPage', function() {
if (cr.isChromeOS) {
assertTrue(inputMethodSettingsExist);
var manageInputMethodsButton =
- inputMethodsCollapse.querySelector('.list-button:last-of-type');
+ inputMethodsCollapse.querySelector('#manageInputMethodsButton');
MockInteractions.tap(manageInputMethodsButton);
assertTrue(!!languagesPage.$$('settings-manage-input-methods-page'));
} else {
@@ -451,7 +451,7 @@ TEST_F('SettingsLanguagesPageBrowserTest', 'MAYBE_LanguagesPage', function() {
});
if (!cr.isMac) {
- test('spellcheck edit dictionary page add word button', function() {
+ test('spellcheck edit dictionary page add word validation', function() {
assertFalse(!!languagesPage.$$('settings-edit-dictionary-page'));
var spellCheckCollapse = languagesPage.$.spellCheckCollapse;
MockInteractions.tap(

Powered by Google App Engine
This is Rietveld 408576698