chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java - Issue 2682863002: [Android] Explicitly request all needed runtime permissions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java

Issue 2682863002: [Android] Explicitly request all needed runtime permissions. (Closed)

Patch Set: Nit Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java » ('j') | chrome/browser/android/preferences/pref_service_bridge.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java

index 97cc3b3bcff1c88b293a630569df35ca3dc1b4b6..86d7c69a548890ced1fbb28d658479f60fa6df96 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java

@@ -70,6 +70,7 @@ import org.chromium.chrome.browser.omnibox.VoiceSuggestionProvider.VoiceResult;

import org.chromium.chrome.browser.omnibox.geo.GeolocationHeader;

import org.chromium.chrome.browser.omnibox.geo.GeolocationSnackbarController;

import org.chromium.chrome.browser.pageinfo.WebsiteSettingsPopup;

+import org.chromium.chrome.browser.preferences.PrefServiceBridge;

import org.chromium.chrome.browser.preferences.privacy.PrivacyPreferencesManager;

import org.chromium.chrome.browser.profiles.Profile;

import org.chromium.chrome.browser.search_engines.TemplateUrlService;

@@ -2389,8 +2390,7 @@ public class LocationBarLayout extends FrameLayout

}

};

- mWindowAndroid.requestPermissions(

- new String[] {Manifest.permission.RECORD_AUDIO}, callback);

+ mWindowAndroid.requestPermissions(PrefServiceBridge.CAMERA_PERMISSIONS, callback);

} else {

updateMicButtonState();

}