Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2845)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java

Issue 2682863002: [Android] Explicitly request all needed runtime permissions. (Closed)
Patch Set: Address mlamouri@ comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java
index fa9c7a643889bf56b769efaa148835b1c52fdb38..e11172806556d25b9e57d204b27183f7837caf50 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java
@@ -426,8 +426,8 @@ public class ExternalNavigationDelegateImpl implements ExternalNavigationDelegat
return false;
}
- return !tab.getWindowAndroid().hasPermission(permission.WRITE_EXTERNAL_STORAGE)
- && tab.getWindowAndroid().canRequestPermission(permission.WRITE_EXTERNAL_STORAGE);
+ return !tab.getWindowAndroid().hasPermission(permission.READ_EXTERNAL_STORAGE)
+ && tab.getWindowAndroid().canRequestPermission(permission.READ_EXTERNAL_STORAGE);
}
@Override
@@ -450,7 +450,7 @@ public class ExternalNavigationDelegateImpl implements ExternalNavigationDelegat
}
};
tab.getWindowAndroid().requestPermissions(
- new String[] {permission.WRITE_EXTERNAL_STORAGE}, permissionCallback);
+ new String[] {permission.READ_EXTERNAL_STORAGE}, permissionCallback);
}
private void loadIntent(Intent intent, String referrerUrl, String fallbackUrl, Tab tab,

Powered by Google App Engine
This is Rietveld 408576698