Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3948)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java

Issue 2682863002: [Android] Explicitly request all needed runtime permissions. (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java
index c954ec50fe2cf2f337a3d594dece85e805614cac..01738c59a9eb6a82f16d6bff6088b97498655cc1 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java
@@ -426,8 +426,8 @@ public class ExternalNavigationDelegateImpl implements ExternalNavigationDelegat
return false;
}
- return !tab.getWindowAndroid().hasPermission(permission.WRITE_EXTERNAL_STORAGE)
- && tab.getWindowAndroid().canRequestPermission(permission.WRITE_EXTERNAL_STORAGE);
+ return !tab.getWindowAndroid().hasPermission(permission.READ_EXTERNAL_STORAGE)
+ && tab.getWindowAndroid().canRequestPermission(permission.READ_EXTERNAL_STORAGE);
}
@Override
@@ -450,7 +450,7 @@ public class ExternalNavigationDelegateImpl implements ExternalNavigationDelegat
}
};
tab.getWindowAndroid().requestPermissions(
- new String[] {permission.WRITE_EXTERNAL_STORAGE}, permissionCallback);
+ new String[] {permission.READ_EXTERNAL_STORAGE}, permissionCallback);
}
private void loadIntent(Intent intent, String referrerUrl, String fallbackUrl, Tab tab,
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698