Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Unified Diff: tests/compiler/dart2js/kernel/loops_test.dart

Issue 2682823002: Fix the loops break label test with Kernel. (Closed)
Patch Set: . Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/ssa/loop_handler.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/kernel/loops_test.dart
diff --git a/tests/compiler/dart2js/kernel/loops_test.dart b/tests/compiler/dart2js/kernel/loops_test.dart
index 42ff8541726169ef073f50c47a690888547a646e..13a75e759e82f50e6ae6d5a719e7ee500c2c631b 100644
--- a/tests/compiler/dart2js/kernel/loops_test.dart
+++ b/tests/compiler/dart2js/kernel/loops_test.dart
@@ -83,9 +83,7 @@ main() {
return check(code, disableTypeInference: false);
});
- // TODO(efortuna): Fix and uncomment.
- // See bug https://github.com/dart-lang/sdk/issues/28670
- /*test('for loop with break to label', () {
+ test('for loop with break to label', () {
String code = '''
var a = 0;
main() {
@@ -100,5 +98,5 @@ main() {
return sum;
}''';
return check(code, disableTypeInference: false);
- });*/
+ });
}
« no previous file with comments | « pkg/compiler/lib/src/ssa/loop_handler.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698