Add NoSourceLocationMarker in old source-info engine.

Add NoSourceLocationMarker in old source-info engine.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/eb411556e660a57cefb497fc613eae9177e46696

[Johnni Winther, 2017-02-09 14:46:40]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-02-09 21:58:41]

lgtm

minor suggestions on the test runner - if we are switching to testing.dart it
might not matter anyways

https://codereview.chromium.org/2682813005/diff/20001/tests/compiler/dart2js/...
File tests/compiler/dart2js/sourcemaps/nomapping_test.dart (right):

https://codereview.chromium.org/2682813005/diff/20001/tests/compiler/dart2js/...
tests/compiler/dart2js/sourcemaps/nomapping_test.dart:32: for (String arg in
arguments) {
seems like a lot of this is in common with the other tests, might not be worth
refactoring, but something to keep in mind.

https://codereview.chromium.org/2682813005/diff/20001/tests/compiler/dart2js/...
tests/compiler/dart2js/sourcemaps/nomapping_test.dart:50: indices = new
List<int>.generate(TESTS.length * 2, (i) => i);
nit: might be simpler to follow below if you do:
for (int index = 0; i < TESTS.length; i++) {
  for (bool useNewSourceInfo in [false, true]) {
    ...
  }
}

It would mean an extra option if you wanted to run only one of the source-infos
systems on the command line, though

[Johnni Winther, 2017-02-10 08:59:04]

https://codereview.chromium.org/2682813005/diff/20001/tests/compiler/dart2js/...
File tests/compiler/dart2js/sourcemaps/nomapping_test.dart (right):

https://codereview.chromium.org/2682813005/diff/20001/tests/compiler/dart2js/...
tests/compiler/dart2js/sourcemaps/nomapping_test.dart:32: for (String arg in
arguments) {
On 2017/02/09 21:58:41, Siggi Cherem (dart-lang) wrote:
> seems like a lot of this is in common with the other tests, might not be worth
> refactoring, but something to keep in mind.

Copied, but they tend to drift over time.

https://codereview.chromium.org/2682813005/diff/20001/tests/compiler/dart2js/...
tests/compiler/dart2js/sourcemaps/nomapping_test.dart:50: indices = new
List<int>.generate(TESTS.length * 2, (i) => i);
On 2017/02/09 21:58:41, Siggi Cherem (dart-lang) wrote:
> nit: might be simpler to follow below if you do:
> for (int index = 0; i < TESTS.length; i++) {
>   for (bool useNewSourceInfo in [false, true]) {
>     ...
>   }
> }
> 
> It would mean an extra option if you wanted to run only one of the
source-infos
> systems on the command line, though

The latter was the motivation!

[Johnni Winther, 2017-02-10 09:03:51]

Description was changed from

==========
Add NoSourceLocationMarker in old source-info engine.
==========

to

==========
Add NoSourceLocationMarker in old source-info engine.

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/eb411556e660a57cefb497fc613eae9177e46696
==========

[Johnni Winther, 2017-02-10 09:03:52]

Committed patchset #2 (id:20001) manually as
eb411556e660a57cefb497fc613eae9177e46696 (presubmit successful).