Gtk3: Add themable location bar border color

chrome/browser/themes/theme_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/themes/theme_service.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 
@@ skipping 420 matching lines @@
   switch (id) {
     case ThemeProperties::COLOR_TOOLBAR_BUTTON_ICON:
       return color_utils::HSLShift(
           gfx::kChromeIconGrey,
           GetTint(ThemeProperties::TINT_BUTTONS, incognito));
     case ThemeProperties::COLOR_TOOLBAR_BUTTON_ICON_INACTIVE:
       // The active color is overridden in GtkUi.
       return SkColorSetA(
           GetColor(ThemeProperties::COLOR_TOOLBAR_BUTTON_ICON, incognito),
           0x33);
+    case ThemeProperties::COLOR_TOOLBAR_ENTRY_BORDER:
+      return SkColorSetA(SK_ColorBLACK, 0x4D);

[Evan Stade, 2017/02/08 16:31:12]

should we just re-use COLOR_TOOLBAR_TOP_SEPARATOR?

[Tom (Use chromium acct), 2017/02/08 21:20:25]

I agree with erg that it's better to add the new color.  It would be hard to
find one color that works well with Ambiance, which has a dark frame but a light
toolbar.

     case ThemeProperties::COLOR_TOOLBAR_TOP_SEPARATOR:
     case ThemeProperties::COLOR_TOOLBAR_TOP_SEPARATOR_INACTIVE: {
       const SkColor tab_color =
           GetColor(ThemeProperties::COLOR_TOOLBAR, incognito);
       const int frame_id = (id == ThemeProperties::COLOR_TOOLBAR_TOP_SEPARATOR)
                                ? ThemeProperties::COLOR_FRAME
                                : ThemeProperties::COLOR_FRAME_INACTIVE;
       const SkColor frame_color = GetColor(frame_id, incognito);
       const SeparatorColorKey key(tab_color, frame_color);
       auto i = separator_color_cache_.find(key);
@@ skipping 416 matching lines @@
 
 #if BUILDFLAG(ENABLE_SUPERVISED_USERS)
 bool ThemeService::IsSupervisedUser() const {
   return profile_->IsSupervised();
 }
 
 void ThemeService::SetSupervisedUserTheme() {
   SetCustomDefaultTheme(new SupervisedUserTheme);
 }
 #endif