Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 26828003: Count beforeload separately for isolated worlds (Closed)

Created:
7 years, 2 months ago by philipj_slow
Modified:
7 years, 2 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org, ojan
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Count beforeload separately for isolated worlds BUG=308218 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159909

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M Source/core/dom/Document.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M Source/core/page/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
philipj_slow
Ojan, Eric, since you wrote and reviewed, respectively, the previous patch, you get to review ...
7 years, 2 months ago (2013-10-16 20:05:47 UTC) #1
ojan
7 years, 2 months ago (2013-10-16 20:07:22 UTC) #2
abarth-chromium
m_frame certainly can be null, but that's a rare case.
7 years, 2 months ago (2013-10-16 20:19:15 UTC) #3
philipj_slow
On 2013/10/16 20:19:15, abarth wrote: > m_frame certainly can be null, but that's a rare ...
7 years, 2 months ago (2013-10-17 06:13:41 UTC) #4
abarth-chromium
lgtm Yep.
7 years, 2 months ago (2013-10-17 18:42:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/26828003/1
7 years, 2 months ago (2013-10-17 18:42:09 UTC) #6
commit-bot: I haz the power
7 years, 2 months ago (2013-10-17 22:26:54 UTC) #7
Message was sent while issue was closed.
Change committed as 159909

Powered by Google App Engine
This is Rietveld 408576698