Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2682753002: Rename parser_test_fasta.dart to parser_fasta_test.dart. (Closed)

Created:
3 years, 10 months ago by Paul Berry
Modified:
3 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Rename parser_test_fasta.dart to parser_fasta_test.dart. Tests must be named "..._test.dart" in order to be run by the build bots. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/5c3ad68f13506701471a801ac5f21d4e62dee6ae

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -310 lines) Patch
A + pkg/analyzer/test/generated/parser_fasta_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
D pkg/analyzer/test/generated/parser_test_fasta.dart View 1 chunk +0 lines, -309 lines 0 comments Download
M pkg/analyzer/test/generated/test_all.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 10 months ago (2017-02-07 19:04:30 UTC) #2
scheglov
LGTM
3 years, 10 months ago (2017-02-07 19:05:15 UTC) #3
Paul Berry
3 years, 10 months ago (2017-02-07 19:12:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5c3ad68f13506701471a801ac5f21d4e62dee6ae (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698