Issue 2682593005: Fixes pinch-to-zoom when linking against the 10.11 SDK or newer.

Created:
3 years, 10 months ago by rohitrao (ping after 24h)

Modified:
3 years, 10 months ago

Reviewers:

CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, nona+watch_chromium.org, darin-cc_chromium.org, mac-reviews_chromium.org, James Su

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fixes pinch-to-zoom when linking against the 10.11 SDK or newer. When linking against the 10.11 SDK or newer, the OS will no longer directly call |beginGestureWithEvent:| or |endGestureWithEvent:|. Instead, applications must check the event's phase inside of |magnifyWithEvent:|. Earlier OS versions will still call the old methods, regardless of which SDK is used. This CL adds both compile-time and runtime checks to ensure that the "begin" and "end" helper methods are called exactly once per gesture. BUG=680927

Patch Set 1 #

Patch Set 2 : Fix comment. #

Patch Set 3 : Test #

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+81 lines, -3 lines)			Patch
	M	content/browser/renderer_host/render_widget_host_view_mac.mm	View	1	5 chunks	+65 lines, -3 lines	0 comments	Download
	M	content/browser/renderer_host/render_widget_host_view_mac_unittest.mm	View	1 2	8 chunks	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (8 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

rohitrao (ping after 24h)

The CQ bit was checked by rohitrao@chromium.org to run a CQ dry run

3 years, 10 months ago (2017-02-07 16:07:16 UTC) #1