Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Side by Side Diff: src/runtime/runtime-debug.cc

Issue 2682593003: [debugger] implement legacy debug event listeners via debug delegate. (Closed)
Patch Set: asan fix Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/runtime/runtime-utils.h" 5 #include "src/runtime/runtime-utils.h"
6 6
7 #include "src/arguments.h" 7 #include "src/arguments.h"
8 #include "src/compiler.h" 8 #include "src/compiler.h"
9 #include "src/debug/debug-evaluate.h" 9 #include "src/debug/debug-evaluate.h"
10 #include "src/debug/debug-frames.h" 10 #include "src/debug/debug-frames.h"
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
72 // Adds a JavaScript function as a debug event listener. 72 // Adds a JavaScript function as a debug event listener.
73 // args[0]: debug event listener function to set or null or undefined for 73 // args[0]: debug event listener function to set or null or undefined for
74 // clearing the event listener function 74 // clearing the event listener function
75 // args[1]: object supplied during callback 75 // args[1]: object supplied during callback
76 RUNTIME_FUNCTION(Runtime_SetDebugEventListener) { 76 RUNTIME_FUNCTION(Runtime_SetDebugEventListener) {
77 SealHandleScope shs(isolate); 77 SealHandleScope shs(isolate);
78 DCHECK_EQ(2, args.length()); 78 DCHECK_EQ(2, args.length());
79 CHECK(args[0]->IsJSFunction() || args[0]->IsNullOrUndefined(isolate)); 79 CHECK(args[0]->IsJSFunction() || args[0]->IsNullOrUndefined(isolate));
80 CONVERT_ARG_HANDLE_CHECKED(Object, callback, 0); 80 CONVERT_ARG_HANDLE_CHECKED(Object, callback, 0);
81 CONVERT_ARG_HANDLE_CHECKED(Object, data, 1); 81 CONVERT_ARG_HANDLE_CHECKED(Object, data, 1);
82 isolate->debug()->SetEventListener(callback, data); 82 if (callback->IsJSFunction()) {
83 83 JavaScriptDebugDelegate* delegate = new JavaScriptDebugDelegate(
84 isolate, Handle<JSFunction>::cast(callback), data);
85 isolate->debug()->SetDebugDelegate(delegate, true);
86 } else {
87 isolate->debug()->SetDebugDelegate(nullptr, false);
88 }
84 return isolate->heap()->undefined_value(); 89 return isolate->heap()->undefined_value();
85 } 90 }
86 91
87 92
88 RUNTIME_FUNCTION(Runtime_ScheduleBreak) { 93 RUNTIME_FUNCTION(Runtime_ScheduleBreak) {
89 SealHandleScope shs(isolate); 94 SealHandleScope shs(isolate);
90 DCHECK_EQ(0, args.length()); 95 DCHECK_EQ(0, args.length());
91 isolate->stack_guard()->RequestDebugBreak(); 96 isolate->stack_guard()->RequestDebugBreak();
92 return isolate->heap()->undefined_value(); 97 return isolate->heap()->undefined_value();
93 } 98 }
(...skipping 1751 matching lines...) Expand 10 before | Expand all | Expand 10 after
1845 DCHECK_EQ(1, args.length()); 1850 DCHECK_EQ(1, args.length());
1846 HandleScope scope(isolate); 1851 HandleScope scope(isolate);
1847 CONVERT_ARG_HANDLE_CHECKED(JSObject, promise, 0); 1852 CONVERT_ARG_HANDLE_CHECKED(JSObject, promise, 0);
1848 isolate->PushPromise(promise); 1853 isolate->PushPromise(promise);
1849 int id = isolate->debug()->NextAsyncTaskId(promise); 1854 int id = isolate->debug()->NextAsyncTaskId(promise);
1850 Handle<Symbol> async_stack_id_symbol = 1855 Handle<Symbol> async_stack_id_symbol =
1851 isolate->factory()->promise_async_stack_id_symbol(); 1856 isolate->factory()->promise_async_stack_id_symbol();
1852 JSObject::SetProperty(promise, async_stack_id_symbol, 1857 JSObject::SetProperty(promise, async_stack_id_symbol,
1853 handle(Smi::FromInt(id), isolate), STRICT) 1858 handle(Smi::FromInt(id), isolate), STRICT)
1854 .Assert(); 1859 .Assert();
1855 isolate->debug()->OnAsyncTaskEvent(debug::kDebugEnqueueAsyncFunction, id); 1860 isolate->debug()->OnAsyncTaskEvent(debug::kDebugEnqueueAsyncFunction, id, 0);
1856 return isolate->heap()->undefined_value(); 1861 return isolate->heap()->undefined_value();
1857 } 1862 }
1858 1863
1859 RUNTIME_FUNCTION(Runtime_DebugPromiseReject) { 1864 RUNTIME_FUNCTION(Runtime_DebugPromiseReject) {
1860 HandleScope scope(isolate); 1865 HandleScope scope(isolate);
1861 DCHECK_EQ(2, args.length()); 1866 DCHECK_EQ(2, args.length());
1862 CONVERT_ARG_HANDLE_CHECKED(JSPromise, rejected_promise, 0); 1867 CONVERT_ARG_HANDLE_CHECKED(JSPromise, rejected_promise, 0);
1863 CONVERT_ARG_HANDLE_CHECKED(Object, value, 1); 1868 CONVERT_ARG_HANDLE_CHECKED(Object, value, 1);
1864 1869
1865 isolate->debug()->OnPromiseReject(rejected_promise, value); 1870 isolate->debug()->OnPromiseReject(rejected_promise, value);
1866 return isolate->heap()->undefined_value(); 1871 return isolate->heap()->undefined_value();
1867 } 1872 }
1868 1873
1869 RUNTIME_FUNCTION(Runtime_DebugAsyncEventEnqueueRecurring) { 1874 RUNTIME_FUNCTION(Runtime_DebugAsyncEventEnqueueRecurring) {
1870 HandleScope scope(isolate); 1875 HandleScope scope(isolate);
1871 DCHECK_EQ(2, args.length()); 1876 DCHECK_EQ(2, args.length());
1872 CONVERT_ARG_HANDLE_CHECKED(JSPromise, promise, 0); 1877 CONVERT_ARG_HANDLE_CHECKED(JSPromise, promise, 0);
1873 CONVERT_SMI_ARG_CHECKED(status, 1); 1878 CONVERT_SMI_ARG_CHECKED(status, 1);
1874 if (isolate->debug()->is_active()) { 1879 if (isolate->debug()->is_active()) {
1875 isolate->debug()->OnAsyncTaskEvent( 1880 isolate->debug()->OnAsyncTaskEvent(
1876 status == v8::Promise::kFulfilled ? debug::kDebugEnqueuePromiseResolve 1881 status == v8::Promise::kFulfilled ? debug::kDebugEnqueuePromiseResolve
1877 : debug::kDebugEnqueuePromiseReject, 1882 : debug::kDebugEnqueuePromiseReject,
1878 isolate->debug()->NextAsyncTaskId(promise)); 1883 isolate->debug()->NextAsyncTaskId(promise), 0);
1879 } 1884 }
1880 return isolate->heap()->undefined_value(); 1885 return isolate->heap()->undefined_value();
1881 } 1886 }
1882 1887
1883 RUNTIME_FUNCTION(Runtime_DebugIsActive) { 1888 RUNTIME_FUNCTION(Runtime_DebugIsActive) {
1884 SealHandleScope shs(isolate); 1889 SealHandleScope shs(isolate);
1885 return Smi::FromInt(isolate->debug()->is_active()); 1890 return Smi::FromInt(isolate->debug()->is_active());
1886 } 1891 }
1887 1892
1888 1893
1889 RUNTIME_FUNCTION(Runtime_DebugBreakInOptimizedCode) { 1894 RUNTIME_FUNCTION(Runtime_DebugBreakInOptimizedCode) {
1890 UNIMPLEMENTED(); 1895 UNIMPLEMENTED();
1891 return NULL; 1896 return NULL;
1892 } 1897 }
1893 1898
1894 } // namespace internal 1899 } // namespace internal
1895 } // namespace v8 1900 } // namespace v8
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698