Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 2682593002: Refactor ContentViewClient (4/6) (Closed)
Patch Set: shell vad Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
index 78232fadca835332a2681f6939a556bc620979a8..6d4807151870a877bedb575ad17594476883b98d 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
@@ -828,11 +828,6 @@ public class ContentViewCore implements AccessibilityStateChangeListener, Displa
return mContentViewClient;
}
- @CalledByNative
- private void onBackgroundColorChanged(int color) {
- getContentViewClient().onBackgroundColorChanged(color);
- }
-
/**
* @return Viewport width in physical pixels as set from onSizeChanged.
*/
@@ -1804,7 +1799,6 @@ public class ContentViewCore implements AccessibilityStateChangeListener, Displa
float minPageScaleFactor, float maxPageScaleFactor, float contentWidth,
float contentHeight, float viewportWidth, float viewportHeight,
float browserControlsHeightDp, float browserControlsShownRatio,
- float bottomControlsHeightDp, float bottomControlsShownRatio,
boolean isMobileOptimizedHint, boolean hasInsertionMarker,
boolean isInsertionMarkerVisible, float insertionMarkerHorizontal,
float insertionMarkerTop, float insertionMarkerBottom) {
@@ -1819,8 +1813,6 @@ public class ContentViewCore implements AccessibilityStateChangeListener, Displa
mViewportHeightPix / (deviceScale * pageScaleFactor));
final float topBarShownPix =
browserControlsHeightDp * deviceScale * browserControlsShownRatio;
- final float bottomBarShownPix = bottomControlsHeightDp * deviceScale
- * bottomControlsShownRatio;
final boolean contentSizeChanged =
contentWidth != mRenderCoordinates.getContentWidthCss()
@@ -1836,8 +1828,6 @@ public class ContentViewCore implements AccessibilityStateChangeListener, Displa
|| scrollOffsetY != mRenderCoordinates.getScrollY();
final boolean topBarChanged = Float.compare(topBarShownPix,
mRenderCoordinates.getContentOffsetYPix()) != 0;
- final boolean bottomBarChanged = Float.compare(bottomBarShownPix, mRenderCoordinates
- .getContentOffsetYPixBottom()) != 0;
final boolean needHidePopupZoomer = contentSizeChanged || scrollChanged;
@@ -1856,7 +1846,7 @@ public class ContentViewCore implements AccessibilityStateChangeListener, Displa
contentWidth, contentHeight,
viewportWidth, viewportHeight,
pageScaleFactor, minPageScaleFactor, maxPageScaleFactor,
- topBarShownPix, bottomBarShownPix);
+ topBarShownPix);
if (scrollChanged || topBarChanged) {
for (mGestureStateListenersIterator.rewind();
@@ -1875,15 +1865,6 @@ public class ContentViewCore implements AccessibilityStateChangeListener, Displa
}
}
- if (topBarChanged) {
- float topBarTranslate = topBarShownPix - browserControlsHeightDp * deviceScale;
- getContentViewClient().onTopControlsChanged(topBarTranslate, topBarShownPix);
- }
- if (bottomBarChanged) {
- float bottomBarTranslate = bottomControlsHeightDp * deviceScale - bottomBarShownPix;
- getContentViewClient().onBottomControlsChanged(bottomBarTranslate, bottomBarShownPix);
- }
-
if (mBrowserAccessibilityManager != null) {
mBrowserAccessibilityManager.notifyFrameInfoInitialized();
}
@@ -2303,11 +2284,6 @@ public class ContentViewCore implements AccessibilityStateChangeListener, Displa
return mRenderCoordinates.getPageScaleFactor();
}
- @CalledByNative
- private void startContentIntent(String contentUrl, boolean isMainFrame) {
- getContentViewClient().onStartContentIntent(getContext(), contentUrl, isMainFrame);
- }
-
@Override
public void onAccessibilityStateChanged(boolean enabled) {
setAccessibilityState(enabled);

Powered by Google App Engine
This is Rietveld 408576698