android_webview/java/src/org/chromium/android_webview/AwContents.java - Issue 2682593002: Refactor ContentViewClient (4/6)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwContents.java

Issue 2682593002: Refactor ContentViewClient (4/6) (Closed)

Patch Set: shell vad Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/java/src/org/chromium/android_webview/AwContentViewClient.java ('k') | android_webview/java/src/org/chromium/android_webview/AwViewAndroidDelegate.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/java/src/org/chromium/android_webview/AwContents.java

diff --git a/android_webview/java/src/org/chromium/android_webview/AwContents.java b/android_webview/java/src/org/chromium/android_webview/AwContents.java

index 83b915080fbc499ee6873cd56f227c10b33bb5bf..7c8df9fe3e2ddef444d38070d347ed86213215b2 100644

--- a/android_webview/java/src/org/chromium/android_webview/AwContents.java

+++ b/android_webview/java/src/org/chromium/android_webview/AwContents.java

@@ -762,7 +762,7 @@ public class AwContents implements SmartClipProvider, PostMessageSender.PostMess

mAwViewMethods = new AwViewMethodsImpl();

mFullScreenTransitionsState = new FullScreenTransitionsState(

mContainerView, mInternalAccessAdapter, mAwViewMethods);

- mContentViewClient = new AwContentViewClient(contentsClient, settings, this, mContext);

+ mContentViewClient = new AwContentViewClient(contentsClient, settings, this);

mLayoutSizer = dependencyFactory.createLayoutSizer();

mSettings = settings;

mLayoutSizer.setDelegate(new AwLayoutSizerDelegate());

@@ -1056,7 +1056,7 @@ public class AwContents implements SmartClipProvider, PostMessageSender.PostMess

mWindowAndroid = getWindowAndroid(mContext);

mContentViewCore = new ContentViewCore(mContext, PRODUCT_VERSION);

mViewAndroidDelegate = new AwViewAndroidDelegate(mContainerView,

- mContentViewCore.getRenderCoordinates());

+ mContentsClient, mContentViewCore.getRenderCoordinates());

initializeContentViewCore(mContentViewCore, mContext, mViewAndroidDelegate,

mInternalAccessAdapter, webContents, new AwGestureStateListener(),

mContentViewClient, mWindowAndroid.getWindowAndroid());