Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Unified Diff: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

Issue 2682573002: Split EBreak enum into EBreakBetween & EBreakInside (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
diff --git a/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
index 58759220b520dac5aea3394ea0cc8b8ac080a8f5..6ec99438cb172af3c5e07886135e7d16890a44e8 100644
--- a/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
+++ b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
@@ -1906,40 +1906,65 @@ static CSSValue* valueForScrollSnapCoordinate(
return list;
}
-// Returns a suitable value for the page-break-(before|after|inside) property,
-// given the computed value of the more general break-(before|after|inside)
-// property.
-static CSSValue* valueForPageBreak(EBreak breakValue) {
+// Returns a suitable value for the page-break-(before|after) property, given
+// the computed value of the more general break-(before|after) property.
+static CSSValue* valueForPageBreak(EBreakBetween breakValue) {
switch (breakValue) {
- case BreakAvoidColumn:
- case BreakColumn:
- case BreakRecto:
- case BreakVerso:
+ case EBreakBetween::kAvoidColumn:
+ case EBreakBetween::kColumn:
+ case EBreakBetween::kRecto:
+ case EBreakBetween::kVerso:
return CSSIdentifierValue::create(CSSValueAuto);
- case BreakPage:
+ case EBreakBetween::kPage:
return CSSIdentifierValue::create(CSSValueAlways);
- case BreakAvoidPage:
+ case EBreakBetween::kAvoidPage:
return CSSIdentifierValue::create(CSSValueAvoid);
default:
return CSSIdentifierValue::create(breakValue);
}
}
-// Returns a suitable value for the -webkit-column-break-(before|after|inside)
-// property, given the computed value of the more general
-// break-(before|after|inside) property.
-static CSSValue* valueForWebkitColumnBreak(EBreak breakValue) {
+// Returns a suitable value for the -webkit-column-break-(before|after)
+// property, given the computed value of the more general break-(before|after)
+// property.
+static CSSValue* valueForWebkitColumnBreak(EBreakBetween breakValue) {
switch (breakValue) {
- case BreakAvoidPage:
- case BreakLeft:
- case BreakPage:
- case BreakRecto:
- case BreakRight:
- case BreakVerso:
+ case EBreakBetween::kAvoidPage:
+ case EBreakBetween::kLeft:
+ case EBreakBetween::kPage:
+ case EBreakBetween::kRecto:
+ case EBreakBetween::kRight:
+ case EBreakBetween::kVerso:
return CSSIdentifierValue::create(CSSValueAuto);
- case BreakColumn:
+ case EBreakBetween::kColumn:
return CSSIdentifierValue::create(CSSValueAlways);
- case BreakAvoidColumn:
+ case EBreakBetween::kAvoidColumn:
+ return CSSIdentifierValue::create(CSSValueAvoid);
+ default:
+ return CSSIdentifierValue::create(breakValue);
+ }
+}
+
+// Returns a suitable value for the page-break-inside property, given the
+// computed value of the more general break-inside property.
+static CSSValue* valueForPageBreak(EBreakInside breakValue) {
+ switch (breakValue) {
+ case EBreakInside::kAvoidColumn:
+ return CSSIdentifierValue::create(CSSValueAuto);
+ case EBreakInside::kAvoidPage:
+ return CSSIdentifierValue::create(CSSValueAvoid);
+ default:
+ return CSSIdentifierValue::create(breakValue);
+ }
+}
+
+// Returns a suitable value for the -webkit-column-break-inside property, given
+// the computed value of the more general break-inside property.
+static CSSValue* valueForWebkitColumnBreak(EBreakInside breakValue) {
+ switch (breakValue) {
+ case EBreakInside::kAvoidPage:
+ return CSSIdentifierValue::create(CSSValueAuto);
+ case EBreakInside::kAvoidColumn:
return CSSIdentifierValue::create(CSSValueAvoid);
default:
return CSSIdentifierValue::create(breakValue);

Powered by Google App Engine
This is Rietveld 408576698