Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2682553002: Fix lingering switch statement test failures. (Closed)

Created:
3 years, 10 months ago by Emily Fortuna
Modified:
3 years, 10 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix lingering switch statement test failures. BUG= R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/0eb961850a3768d7579d3fb006cb1b4e470568ea

Patch Set 1 : . #

Total comments: 2

Patch Set 2 : associateNode #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -32 lines) Patch
M pkg/compiler/lib/src/kernel/kernel_visitor.dart View 1 5 chunks +13 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 1 2 chunks +12 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 1 3 chunks +15 lines, -14 lines 0 comments Download
M pkg/compiler/lib/src/ssa/switch_continue_analysis.dart View 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Emily Fortuna
running updated test numbers now.
3 years, 10 months ago (2017-02-07 00:39:51 UTC) #3
sra1
https://codereview.chromium.org/2682553002/diff/20001/pkg/compiler/lib/src/resolution/members.dart File pkg/compiler/lib/src/resolution/members.dart (right): https://codereview.chromium.org/2682553002/diff/20001/pkg/compiler/lib/src/resolution/members.dart#newcode4606 pkg/compiler/lib/src/resolution/members.dart:4606: Set<SwitchCase> switchCasesWithContinues = new HashSet<SwitchCase>(); I'd just say new ...
3 years, 10 months ago (2017-02-07 01:05:07 UTC) #4
Emily Fortuna
https://codereview.chromium.org/2682553002/diff/20001/pkg/compiler/lib/src/resolution/members.dart File pkg/compiler/lib/src/resolution/members.dart (right): https://codereview.chromium.org/2682553002/diff/20001/pkg/compiler/lib/src/resolution/members.dart#newcode4606 pkg/compiler/lib/src/resolution/members.dart:4606: Set<SwitchCase> switchCasesWithContinues = new HashSet<SwitchCase>(); On 2017/02/07 01:05:06, sra1 ...
3 years, 10 months ago (2017-02-07 01:30:56 UTC) #5
sra1
lgtm
3 years, 10 months ago (2017-02-07 18:36:08 UTC) #8
Emily Fortuna
3 years, 10 months ago (2017-02-07 18:38:39 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:80001) manually as
0eb961850a3768d7579d3fb006cb1b4e470568ea (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698