Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Side by Side Diff: components/autofill/content/renderer/password_autofill_agent.h

Issue 2682473002: Show Login Not Secure on username field even without Autocomplete attribute (Closed)
Patch Set: Correct ordering of private fields Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_AUTOFILL_CONTENT_RENDERER_PASSWORD_AUTOFILL_AGENT_H_ 5 #ifndef COMPONENTS_AUTOFILL_CONTENT_RENDERER_PASSWORD_AUTOFILL_AGENT_H_
6 #define COMPONENTS_AUTOFILL_CONTENT_RENDERER_PASSWORD_AUTOFILL_AGENT_H_ 6 #define COMPONENTS_AUTOFILL_CONTENT_RENDERER_PASSWORD_AUTOFILL_AGENT_H_
7 7
8 #include <map> 8 #include <map>
9 #include <memory> 9 #include <memory>
10 #include <vector> 10 #include <vector>
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 bool PreviewSuggestion(const blink::WebFormControlElement& node, 76 bool PreviewSuggestion(const blink::WebFormControlElement& node,
77 const blink::WebString& username, 77 const blink::WebString& username,
78 const blink::WebString& password); 78 const blink::WebString& password);
79 79
80 // Clears the preview for the username and password fields, restoring both to 80 // Clears the preview for the username and password fields, restoring both to
81 // their previous filled state. Return false if no login information was 81 // their previous filled state. Return false if no login information was
82 // found for the form. 82 // found for the form.
83 bool DidClearAutofillSelection( 83 bool DidClearAutofillSelection(
84 const blink::WebFormControlElement& control_element); 84 const blink::WebFormControlElement& control_element);
85 85
86 // If the form is non-secure, show the "Not Secure" warning on username and
87 // password input fields.
88 bool ShouldShowNotSecureWarning(const blink::WebInputElement& element);
89
86 // Shows an Autofill popup with username suggestions for |element|. If 90 // Shows an Autofill popup with username suggestions for |element|. If
87 // |show_all| is |true|, will show all possible suggestions for that element, 91 // |show_all| is |true|, will show all possible suggestions for that element,
88 // otherwise shows suggestions based on current value of |element|. 92 // otherwise shows suggestions based on current value of |element|.
89 // If |generation_popup_showing| is true, this function will return false 93 // If |generation_popup_showing| is true, this function will return false
90 // as both UIs should not be shown at the same time. This function should 94 // as both UIs should not be shown at the same time. This function should
91 // still be called in this situation so that UMA stats can be logged. 95 // still be called in this situation so that UMA stats can be logged.
92 // Returns true if any suggestions were shown, false otherwise. 96 // Returns true if any suggestions were shown, false otherwise.
93 bool ShowSuggestions(const blink::WebInputElement& element, 97 bool ShowSuggestions(const blink::WebInputElement& element,
94 bool show_all, 98 bool show_all,
95 bool generation_popup_showing); 99 bool generation_popup_showing);
(...skipping 188 matching lines...) Expand 10 before | Expand all | Expand 10 after
284 mojom::PasswordManagerDriverPtr password_manager_driver_; 288 mojom::PasswordManagerDriverPtr password_manager_driver_;
285 289
286 mojo::Binding<mojom::PasswordAutofillAgent> binding_; 290 mojo::Binding<mojom::PasswordAutofillAgent> binding_;
287 291
288 DISALLOW_COPY_AND_ASSIGN(PasswordAutofillAgent); 292 DISALLOW_COPY_AND_ASSIGN(PasswordAutofillAgent);
289 }; 293 };
290 294
291 } // namespace autofill 295 } // namespace autofill
292 296
293 #endif // COMPONENTS_AUTOFILL_CONTENT_RENDERER_PASSWORD_AUTOFILL_AGENT_H_ 297 #endif // COMPONENTS_AUTOFILL_CONTENT_RENDERER_PASSWORD_AUTOFILL_AGENT_H_
OLDNEW
« no previous file with comments | « chrome/test/data/password/password_form.html ('k') | components/autofill/content/renderer/password_autofill_agent.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698