Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Side by Side Diff: pkg/front_end/test/subpackage_relationships_test.dart

Issue 2682423003: Unify fasta->analyzer token translation logic. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import 'dart:async'; 5 import 'dart:async';
6 import 'dart:io'; 6 import 'dart:io';
7 7
8 import 'package:front_end/compiler_options.dart'; 8 import 'package:front_end/compiler_options.dart';
9 import 'package:front_end/dependency_grapher.dart'; 9 import 'package:front_end/dependency_grapher.dart';
10 import 'package:path/path.dart' as pathos; 10 import 'package:path/path.dart' as pathos;
(...skipping 24 matching lines...) Expand all
35 new SubpackageRules(mayImportAnalyzer: true, allowedDependencies: [ 35 new SubpackageRules(mayImportAnalyzer: true, allowedDependencies: [
36 'lib/src/fasta/builder', 36 'lib/src/fasta/builder',
37 'lib/src/fasta/dill', 37 'lib/src/fasta/dill',
38 'lib/src/fasta/kernel', 38 'lib/src/fasta/kernel',
39 'lib/src/fasta/parser', 39 'lib/src/fasta/parser',
40 'lib/src/fasta/scanner', 40 'lib/src/fasta/scanner',
41 'lib/src/fasta/testing', 41 'lib/src/fasta/testing',
42 ]), 42 ]),
43 'lib/src/fasta/analyzer': 43 'lib/src/fasta/analyzer':
44 new SubpackageRules(mayImportAnalyzer: true, allowedDependencies: [ 44 new SubpackageRules(mayImportAnalyzer: true, allowedDependencies: [
45 'lib/src/scanner',
45 'lib/src/fasta', 46 'lib/src/fasta',
46 'lib/src/fasta/builder', 47 'lib/src/fasta/builder',
47 'lib/src/fasta/dill', 48 'lib/src/fasta/dill',
48 'lib/src/fasta/kernel', 49 'lib/src/fasta/kernel',
49 'lib/src/fasta/scanner', 50 'lib/src/fasta/scanner',
50 'lib/src/fasta/source', 51 'lib/src/fasta/source',
51 ]), 52 ]),
52 'lib/src/fasta/bin': new SubpackageRules(allowedDependencies: [ 53 'lib/src/fasta/bin': new SubpackageRules(allowedDependencies: [
53 'lib/src/fasta', 54 'lib/src/fasta',
54 ]), 55 ]),
(...skipping 172 matching lines...) Expand 10 before | Expand all | Expand 10 after
227 problem('Uri $src is inside package:front_end but is not in any known ' 228 problem('Uri $src is inside package:front_end but is not in any known '
228 'subpackage'); 229 'subpackage');
229 } else if (!subpackageRules[subpackage].allowSubdirs && 230 } else if (!subpackageRules[subpackage].allowSubdirs &&
230 pathWithinSubpackage.contains('/')) { 231 pathWithinSubpackage.contains('/')) {
231 problem('Uri $src is in a subfolder of $subpackage, but that ' 232 problem('Uri $src is in a subfolder of $subpackage, but that '
232 'subpackage does not allow dart files in subdirectories.'); 233 'subpackage does not allow dart files in subdirectories.');
233 } 234 }
234 return subpackage; 235 return subpackage;
235 } 236 }
236 } 237 }
OLDNEW
« pkg/front_end/lib/src/fasta/analyzer/token_utils.dart ('K') | « pkg/front_end/test/scanner_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698