Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issue 26824002: Truncate booleans to 0/1 in truncating t-to-i. (Closed)

Created:
7 years, 2 months ago by oliv
Modified:
7 years, 2 months ago
CC:
v8-dev
Visibility:
Public.

Description

Truncate booleans to 0/1 in truncating t-to-i. Thanks to weiliang.lin2@gmail.com for discovering the issue. BUG= R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17166

Patch Set 1 #

Patch Set 2 : port #

Patch Set 3 : rebase #

Patch Set 4 : fix the non-truncating sites #

Patch Set 5 : add a testcase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -97 lines) Patch
M src/arm/lithium-codegen-arm.cc View 1 1 chunk +22 lines, -7 lines 0 comments Download
M src/code-stubs.cc View 1 2 3 2 chunks +10 lines, -7 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 1 chunk +20 lines, -9 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 1 chunk +22 lines, -8 lines 0 comments Download
A + test/mjsunit/bitwise-operations-bools.js View 1 2 3 4 1 chunk +54 lines, -66 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
oliv
7 years, 2 months ago (2013-10-10 12:02:04 UTC) #1
Benedikt Meurer
Is there a test case for this?
7 years, 2 months ago (2013-10-11 12:08:13 UTC) #2
oliv
On 2013/10/11 12:08:13, Benedikt Meurer wrote: > Is there a test case for this? yes ...
7 years, 2 months ago (2013-10-11 12:25:44 UTC) #3
Benedikt Meurer
LGTM
7 years, 2 months ago (2013-10-11 12:32:29 UTC) #4
oliv
7 years, 2 months ago (2013-10-11 15:13:18 UTC) #5
Message was sent while issue was closed.
Committed patchset #5 manually as r17166 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698