test.dart: Dump stack traces for child processes on timeout.

test.dart: Dump stack traces for child processes on timeout.

This should help flaky timeout debugging for tests that spawn child processes.

R=zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/20e736e6cacec029700a3937887d9119d28914a6

[Florian Schneider, 2017-02-09 21:52:09]

Description was changed from

==========
test.dart: Dump stack traces for child processes on timout.

This should help flaky timeout debugging for tests that spawn child processes.
==========

to

==========
test.dart: Dump stack traces for child processes on timeout.

This should help flaky timeout debugging for tests that spawn child processes.
==========

[Florian Schneider, 2017-02-09 21:57:06]

fschneider@google.com changed reviewers:
+ zra@google.com

[zra, 2017-02-09 22:00:46]

https://codereview.chromium.org/2682373004/diff/40001/tools/testing/dart/test...
File tools/testing/dart/test_runner.dart (right):

https://codereview.chromium.org/2682373004/diff/40001/tools/testing/dart/test...
tools/testing/dart/test_runner.dart:1922: if (executable != null) {
This is all getting complicated enough that it probably makes sense to pull this
out into a helper method.

[Florian Schneider, 2017-02-09 23:15:27]

Ptal. Factored getting child pids into a helper.

Also, removed status file entry for a flaky test while debugging the issue.

[zra, 2017-02-09 23:18:15]

lgtm

[Florian Schneider, 2017-02-09 23:34:30]

Description was changed from

==========
test.dart: Dump stack traces for child processes on timeout.

This should help flaky timeout debugging for tests that spawn child processes.
==========

to

==========
test.dart: Dump stack traces for child processes on timeout.

This should help flaky timeout debugging for tests that spawn child processes.

R=zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/20e736e6cacec029700a3937887d9119d28914a6
==========

[Florian Schneider, 2017-02-09 23:34:32]

Committed patchset #5 (id:80001) manually as
20e736e6cacec029700a3937887d9119d28914a6 (presubmit successful).