Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2682343002: Disable the profiler when a debugger is attached (Closed)

Created:
3 years, 10 months ago by Cutch
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Disable the profiler when a debugger is attached Fixes #28702 BUG= R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/95a816652385f55c796328026ac144e5a9390861

Patch Set 1 #

Total comments: 4

Patch Set 2 : vegorov review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -19 lines) Patch
M runtime/vm/thread_interrupter.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/thread_interrupter.cc View 1 6 chunks +15 lines, -6 lines 0 comments Download
M runtime/vm/thread_interrupter_android.cc View 1 1 chunk +7 lines, -2 lines 0 comments Download
M runtime/vm/thread_interrupter_fuchsia.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/thread_interrupter_linux.cc View 1 1 chunk +7 lines, -2 lines 0 comments Download
M runtime/vm/thread_interrupter_macos.cc View 1 3 chunks +27 lines, -1 line 0 comments Download
M runtime/vm/thread_interrupter_win.cc View 1 3 chunks +13 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Cutch
3 years, 10 months ago (2017-02-09 16:59:23 UTC) #3
Vyacheslav Egorov (Google)
LGTM! Thanks. https://codereview.chromium.org/2682343002/diff/1/runtime/vm/thread_interrupter.cc File runtime/vm/thread_interrupter.cc (right): https://codereview.chromium.org/2682343002/diff/1/runtime/vm/thread_interrupter.cc#newcode77 runtime/vm/thread_interrupter.cc:77: OS::Print("ThreadInterrupter disabled because a debugger is attached.\n"); ...
3 years, 10 months ago (2017-02-09 17:14:06 UTC) #4
Cutch
Committed patchset #2 (id:20001) manually as 95a816652385f55c796328026ac144e5a9390861 (presubmit successful).
3 years, 10 months ago (2017-02-09 18:12:01 UTC) #6
Cutch
3 years, 10 months ago (2017-02-09 18:34:07 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/2682343002/diff/1/runtime/vm/thread_interrupt...
File runtime/vm/thread_interrupter.cc (right):

https://codereview.chromium.org/2682343002/diff/1/runtime/vm/thread_interrupt...
runtime/vm/thread_interrupter.cc:77: OS::Print("ThreadInterrupter disabled
because a debugger is attached.\n");
On 2017/02/09 17:14:05, Vyacheslav Egorov (Google) wrote:
> OS::PrintErr?

Done here and elsewhere

https://codereview.chromium.org/2682343002/diff/1/runtime/vm/thread_interrupt...
File runtime/vm/thread_interrupter_macos.cc (right):

https://codereview.chromium.org/2682343002/diff/1/runtime/vm/thread_interrupt...
runtime/vm/thread_interrupter_macos.cc:49: size = sizeof(info);
On 2017/02/09 17:14:05, Vyacheslav Egorov (Google) wrote:
> Maybe better structure this code like this:
> 
> struct kinfo_proc info;
> info.kp_proc.p_flag = 0;
> 
> int mib[4] = {CTL_KERN, KERN_PROC, KERN_PROC_PID, getpid()};
> size_t size = sizeof(info);
> 
> int junk = sysctl(...);
> 
> ...

Done.

Powered by Google App Engine
This is Rietveld 408576698