Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 2682313002: Introduce NavigationSimulator to use in unit tests (Closed)
Patch Set: Added same-page navigation simulation Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_impl.cc
diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc
index 05bf13973d4ea29511853be2075fda1b88a4e29c..ec7df4b7a8db400867bb38b8efd60153bc6ac4c8 100644
--- a/content/browser/frame_host/render_frame_host_impl.cc
+++ b/content/browser/frame_host/render_frame_host_impl.cc
@@ -2527,8 +2527,10 @@ void RenderFrameHostImpl::Navigate(
//
// Blink doesn't send throb notifications for JavaScript URLs, so it is not
// done here either.
- if (!common_params.url.SchemeIs(url::kJavaScriptScheme))
+ if (!common_params.url.SchemeIs(url::kJavaScriptScheme) &&
+ (!navigation_handle_ || !navigation_handle_->is_transferring())) {
OnDidStartLoading(true);
+ }
}
void RenderFrameHostImpl::NavigateToInterstitialURL(const GURL& data_url) {

Powered by Google App Engine
This is Rietveld 408576698