Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1646)

Unified Diff: content/public/test/test_renderer_host.h

Issue 2682313002: Introduce NavigationSimulator to use in unit tests (Closed)
Patch Set: Addressed comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/test/navigation_simulator.cc ('k') | content/test/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/test/test_renderer_host.h
diff --git a/content/public/test/test_renderer_host.h b/content/public/test/test_renderer_host.h
index 657933e7b387088a57d25233f4faf01c89765efd..8dc63b8110928a313354ba2371e5ed27ab56caf7 100644
--- a/content/public/test/test_renderer_host.h
+++ b/content/public/test/test_renderer_host.h
@@ -76,19 +76,28 @@ class RenderFrameHostTester {
// Simulates a renderer-initiated navigation to |url| starting in the
// RenderFrameHost.
+ // DEPRECATED: use NavigationSimulator instead.
virtual void SimulateNavigationStart(const GURL& url) = 0;
// Simulates a redirect to |new_url| for the navigation in the
// RenderFrameHost.
+ // Note: this is deprecated for simulating renderer-initiated navigations. Use
+ // NavigationSimulator instead.
virtual void SimulateRedirect(const GURL& new_url) = 0;
// Simulates a navigation to |url| committing in the RenderFrameHost.
+ // Note: this is deprecated for simulating renderer-initiated navigations. Use
+ // NavigationSimulator instead.
virtual void SimulateNavigationCommit(const GURL& url) = 0;
// Simulates a navigation to |url| failing with the error code |error_code|.
+ // Note: this is deprecated for simulating renderer-initiated navigations. Use
+ // NavigationSimulator instead.
virtual void SimulateNavigationError(const GURL& url, int error_code) = 0;
// Simulates the commit of an error page following a navigation failure.
+ // Note: this is deprecated for simulating renderer-initiated navigations. Use
+ // NavigationSimulator instead.
virtual void SimulateNavigationErrorPageCommit() = 0;
// Simulates a navigation stopping in the RenderFrameHost.
« no previous file with comments | « content/public/test/navigation_simulator.cc ('k') | content/test/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698