Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(821)

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 2682313002: Introduce NavigationSimulator to use in unit tests (Closed)
Patch Set: Addressed comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/frame_host/navigation_handle_impl.cc ('k') | content/public/common/referrer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/render_frame_host_impl.cc
diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc
index cc7e8ca2070e46f98ae50ee55f1d39a9a84b70c3..ff676db56414b28a6a8986670d5def976e6e88b8 100644
--- a/content/browser/frame_host/render_frame_host_impl.cc
+++ b/content/browser/frame_host/render_frame_host_impl.cc
@@ -2469,8 +2469,10 @@ void RenderFrameHostImpl::Navigate(
//
// Blink doesn't send throb notifications for JavaScript URLs, so it is not
// done here either.
- if (!common_params.url.SchemeIs(url::kJavaScriptScheme))
+ if (!common_params.url.SchemeIs(url::kJavaScriptScheme) &&
+ (!navigation_handle_ || !navigation_handle_->is_transferring())) {
OnDidStartLoading(true);
+ }
}
void RenderFrameHostImpl::NavigateToInterstitialURL(const GURL& data_url) {
« no previous file with comments | « content/browser/frame_host/navigation_handle_impl.cc ('k') | content/public/common/referrer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698