Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7009)

Unified Diff: chrome/browser/resources/settings/privacy_page/privacy_page.html

Issue 2682293002: Add desktop UI for the subresource filter content setting. (Closed)
Patch Set: . Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/privacy_page/privacy_page.html
diff --git a/chrome/browser/resources/settings/privacy_page/privacy_page.html b/chrome/browser/resources/settings/privacy_page/privacy_page.html
index 3e2e0de7d61dfd29822b855f83f6444b4bcca30f..2ea29d63f5f644cffa9d3e0d931e345e8beeeda4 100644
--- a/chrome/browser/resources/settings/privacy_page/privacy_page.html
+++ b/chrome/browser/resources/settings/privacy_page/privacy_page.html
@@ -377,7 +377,20 @@
</category-setting-exceptions>
</settings-subpage>
</template>
- <template is="dom-if" route-path="/content/unsandboxedPlugins" no-search>
+ <template is="dom-if" route-path="/content/subresourceFilter" no-search>
tommycli 2017/03/13 19:17:01 also strange indent
melandory 2017/03/20 22:16:19 Done.
+ <settings-subpage page-title="$i18n{siteSettingsSubresourceFilter}">
+ <category-default-setting
+ category="{{ContentSettingsTypes.SUBRESOURCE_FILTER}}"
+ toggle-off-label="$i18n{siteSettingsSubresourceFilterAllow}"
+ toggle-on-label="$i18n{siteSettingsSubresourceFilterBlock}">
+ </category-default-setting>
+ <category-setting-exceptions
+ category="{{ContentSettingsTypes.SUBRESOURCE_FITER}}">
+ </category-setting-exceptions>
+ </settings-subpage>
+ </template>
tommycli 2017/03/13 19:17:01 strange indent.
melandory 2017/03/20 22:16:19 Done.
+ <template is="dom-if" if="isSubresourceFilterVisible_"
+ route-path="/content/unsandboxedPlugins" no-search>
tommycli 2017/03/13 19:17:01 Can you double check this dom-if? It seems to link
melandory 2017/03/20 22:16:19 Done.
<settings-subpage page-title="$i18n{siteSettingsUnsandboxedPlugins}">
<category-default-setting
toggle-off-label="$i18n{siteSettingsUnsandboxedPluginsBlock}"

Powered by Google App Engine
This is Rietveld 408576698