Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5084)

Unified Diff: chrome/browser/profiles/profile_avatar_downloader.cc

Issue 2682263002: Network traffic annotation added to chrome::BitmapFetcher. (Closed)
Patch Set: Comments addressed. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profiles/profile_avatar_downloader.cc
diff --git a/chrome/browser/profiles/profile_avatar_downloader.cc b/chrome/browser/profiles/profile_avatar_downloader.cc
index 6bfb7a882494c0cb9e2e0fdaae5ec4176017af7d..f0cb8e668e7b040bc424b7d6aeef1cc5e23d5832 100644
--- a/chrome/browser/profiles/profile_avatar_downloader.cc
+++ b/chrome/browser/profiles/profile_avatar_downloader.cc
@@ -12,6 +12,7 @@
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/profiles/profile_avatar_icon_util.h"
#include "net/base/load_flags.h"
+#include "net/traffic_annotation/network_traffic_annotation.h"
#include "ui/gfx/image/image.h"
namespace {
@@ -27,7 +28,28 @@ ProfileAvatarDownloader::ProfileAvatarDownloader(
DCHECK(!callback_.is_null());
GURL url(std::string(kHighResAvatarDownloadUrlPrefix) +
profiles::GetDefaultAvatarIconFileNameAtIndex(icon_index));
- fetcher_.reset(new chrome::BitmapFetcher(url, this));
+ net::NetworkTrafficAnnotationTag traffic_annotation =
+ net::DefineNetworkTrafficAnnotation("profile avatar", R"(
+ semantics {
+ sender: "profiles"
+ description:
+ "The Google Chrome binary comes bundles with low-resolution "
+ "versions of the people avatars that are selecting in "
+ "chrome://settings. When an avatar is chosen for a profile, Chrome "
+ "will download the high-resolution version from Google's static "
+ "content servers, for use in the people manager UI."
battre 2017/02/10 08:52:34 Grammar: The Google Chrome binary comes with a bu
Ramin Halavati 2017/02/10 14:40:57 Done.
+ trigger:
+ "User selects a new avatar in chrome://settings for their profile"
+ data: "None, only the filename of the png to download."
+ destination: GOOGLE_OWNED_SERVICE
+ }
+ policy {
+ cookies_allowed: false
+ policy_exception_justification:
+ "No content is being uploaded or saved; this request merely "
+ "downloads a publicly available PNG file."
+ })");
+ fetcher_.reset(new chrome::BitmapFetcher(url, this, traffic_annotation));
}
ProfileAvatarDownloader::~ProfileAvatarDownloader() {

Powered by Google App Engine
This is Rietveld 408576698