Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc

Issue 2682263002: Network traffic annotation added to chrome::BitmapFetcher. (Closed)
Patch Set: nits Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc
diff --git a/chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc b/chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc
index bc890bf6f33b7561581397eecb89d8462661e64d..8dcfd5188c7932d1421295435ed6b2eb2b2ccc96 100644
--- a/chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc
+++ b/chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc
@@ -34,6 +34,7 @@
#include "components/sync/driver/sync_service_utils.h"
#include "content/public/browser/notification_service.h"
#include "extensions/features/features.h"
+#include "net/traffic_annotation/network_traffic_annotation.h"
#if BUILDFLAG(ENABLE_EXTENSIONS)
#include "chrome/browser/autocomplete/keyword_extensions_delegate_impl.h"
@@ -249,7 +250,47 @@ void ChromeAutocompleteProviderClient::PrefetchImage(const GURL& url) {
BitmapFetcherService* image_service =
BitmapFetcherServiceFactory::GetForBrowserContext(profile_);
DCHECK(image_service);
- image_service->Prefetch(url);
+
+ // TODO(jdonnelly, rhalavati): Create a helper function with Callback to
+ // create annotation and pass it to image_service, merging this annotation and
+ // chrome/browser/ui/omnibox/chrome_omnibox_client.cc
+ net::NetworkTrafficAnnotationTag traffic_annotation =
+ net::DefineNetworkTrafficAnnotation("omnibox_prefetch_image", R"(
+ semantics {
+ sender: "Omnibox"
+ description:
+ "Chromium provides answers in the suggestion list for certain "
+ "queries that the user types in the omnibox. This request "
+ "retrieves a small image (for example, an icon illustrating the "
+ "current weather conditions) when this can add information to an "
+ "answer."
+ trigger:
+ "Change of results for the query typed by the user in the "
+ "omnibox."
+ data:
+ "The only data sent is the path to an image. No user data is "
+ "included, although some might be inferrable (e.g. whether the "
+ "weather is sunny or rainy in the user's current location) from "
+ "the name of the image in the path."
+ destination: WEBSITE
+ }
+ policy {
+ cookies_allowed: true
+ cookies_store: "user"
+ setting:
+ "You can enable or disable this feature via 'Use a prediction "
+ "service to help complete searches and URLs typed in the "
+ "address bar.' in Chromium's settings under Advanced. The "
+ "feature is enabled by default."
+ policy {
+ SearchSuggestEnabled {
+ policy_options {mode: MANDATORY}
+ value: false
+ }
+ }
+ })");
+
+ image_service->Prefetch(url, traffic_annotation);
}
void ChromeAutocompleteProviderClient::OnAutocompleteControllerResultReady(
« no previous file with comments | « chrome/browser/android/omnibox/answers_image_bridge.cc ('k') | chrome/browser/bitmap_fetcher/bitmap_fetcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698