Index: chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc |
diff --git a/chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc b/chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc |
index bc890bf6f33b7561581397eecb89d8462661e64d..7332bec566bd241ff96d991e8e22603d48a6dec9 100644 |
--- a/chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc |
+++ b/chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc |
@@ -34,6 +34,7 @@ |
#include "components/sync/driver/sync_service_utils.h" |
#include "content/public/browser/notification_service.h" |
#include "extensions/features/features.h" |
+#include "net/traffic_annotation/network_traffic_annotation.h" |
#if BUILDFLAG(ENABLE_EXTENSIONS) |
#include "chrome/browser/autocomplete/keyword_extensions_delegate_impl.h" |
@@ -249,7 +250,46 @@ void ChromeAutocompleteProviderClient::PrefetchImage(const GURL& url) { |
BitmapFetcherService* image_service = |
BitmapFetcherServiceFactory::GetForBrowserContext(profile_); |
DCHECK(image_service); |
- image_service->Prefetch(url); |
+ |
+ // TODO(jdonnelly, rhalavati): Create a helper function with Callback to |
+ // create annotation and pass it to image_service, merging this annotation and |
+ // chrome/browser/ui/omnibox/chrome_omnibox_client.cc |
+ net::NetworkTrafficAnnotationTag traffic_annotation = |
+ net::DefineNetworkTrafficAnnotation("omnibox_prefetch_image", R"( |
+ semantics { |
+ sender: "Omnibox Suggest Prefetch" |
Peter Kasting
2017/02/24 02:38:22
I wonder if this is too fine-grained.
Over in htt
Ramin Halavati
2017/02/24 07:44:01
We need to have different |sender| texts for diffe
battre
2017/02/24 07:54:23
Actually, I would prefer if the same component reu
|
+ description: |
+ "Google Chrome provides answers in the suggestion list for certain " |
Peter Kasting
2017/02/24 02:41:18
(Sorry for all the separate mails on this stuff)
|
+ "queries that user types in the omnibox. This request retrieves a " |
+ "small image (for example, an icon illustrating the current " |
+ "weather conditions) when this can add information to an answer." |
+ trigger: |
+ "Change of results for the query typed by the user in the " |
+ "omnibox." |
+ data: |
+ "The only data sent is the path to an image. No user data is " |
+ "included, although some might be inferrable (e.g. whether the " |
+ "weather is sunny or rainy in the user's current location) from " |
+ "the name of the image in the path." |
+ destination: WEBSITE |
+ } |
+ policy { |
+ cookies_allowed: true |
+ cookies_store: "user" |
+ setting: |
+ "You can enable or disable this feature via 'Use a prediction " |
+ "service to help complete searches and URLs typed in the " |
+ "address bar.' in Chrome's settings under Advanced. The " |
Peter Kasting
2017/02/24 02:41:18
...similarly here "...in the settings page..."
|
+ "feature is enabled by default." |
+ policy { |
+ SearchSuggestEnabled { |
+ policy_options {mode: MANDATORY} |
+ value: false |
+ } |
+ } |
+ })"); |
+ |
+ image_service->Prefetch(url, traffic_annotation); |
} |
void ChromeAutocompleteProviderClient::OnAutocompleteControllerResultReady( |