Network traffic annotation added to chrome::BitmapFetcher.

chrome/browser/extensions/webstore_install_helper.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/webstore_install_helper.h"
 
 #include "base/bind.h"
 #include "base/values.h"
 #include "chrome/browser/bitmap_fetcher/bitmap_fetcher.h"
 #include "components/safe_json/safe_json_parser.h"
 #include "content/public/browser/browser_thread.h"
 #include "net/base/load_flags.h"
+#include "net/traffic_annotation/network_traffic_annotation.h"
 #include "net/url_request/url_request.h"
 
 using content::BrowserThread;
 
 namespace {
 
 const char kImageDecodeError[] = "Image decode failed";
 
 }  // namespace
 
@@ skipping 23 matching lines @@
   safe_json::SafeJsonParser::Parse(
       manifest_, base::Bind(&WebstoreInstallHelper::OnJSONParseSucceeded, this),
       base::Bind(&WebstoreInstallHelper::OnJSONParseFailed, this));
 
   if (icon_url_.is_empty()) {
     icon_decode_complete_ = true;
   } else {
     // No existing |icon_fetcher_| to avoid unbalanced AddRef().
     CHECK(!icon_fetcher_.get());
     AddRef();  // Balanced in OnFetchComplete().
-    icon_fetcher_.reset(new chrome::BitmapFetcher(icon_url_, this));
+    net::NetworkTrafficAnnotationTag traffic_annotation =
+        net::DefineNetworkTrafficAnnotation("webstore_install_helper", R"(
+          semantics {
+            sender: "Webstore Install Helper"
+            description:
+              "Fetches the bitmap corresponding to an extension icon."
+            trigger:
+              "This can happen in a few different circumstances: "
+              "1-User initiated an install from the Chrome Web Store."
+              "2-User initiated an inline installation from another website."
+              "3-...Something with kiosk apps - maybe steel@ knows more about "

[tbarzic, 2017/02/14 21:24:57]

Loading of kiosk app data on Chrome OS (provided that the kiosk app is a Web
Store app).

Basically, if a kiosk app is set on a Chrome OS device, KioskAppManager will use
WebstoreInstallHelper to fetch the kiosk app data - primarily app icon and the
required platform version information. (note that the fetched data is then
cached locally, so this should happen only on initial app load, or if local data
get's corrupted).

[Ramin Halavati, 2017/02/15 11:52:02]

Done.

+              "that one."
+            data:
+              "The url of the icon for the extension, which includes the "
+              "extension id."
+            destination: GOOGLE_OWNED_SERVICE
+          }
+          policy {
+            cookies_allowed: false
+            setting:
+              "There's no direct Chrome setting to disable this, but you could "
+              "uninstall all extensions and not install (or begin the "
+              "installation flow for) any more."
+            policy {
+              [POLICY_NAME] {
+                policy_options {mode: MANDATORY/RECOMMENDED/UNSET}
+                value: ...
+              }
+            }
+          })");
+    icon_fetcher_.reset(
+        new chrome::BitmapFetcher(icon_url_, this, traffic_annotation));
     icon_fetcher_->Init(
         context_getter_, std::string(),
         net::URLRequest::CLEAR_REFERRER_ON_TRANSITION_FROM_SECURE_TO_INSECURE,
         net::LOAD_DO_NOT_SAVE_COOKIES | net::LOAD_DO_NOT_SEND_COOKIES);
     icon_fetcher_->Start();
   }
 }
 
 void WebstoreInstallHelper::OnFetchComplete(const GURL& url,
                                             const SkBitmap* image) {
@@ skipping 43 matching lines @@
   if (!icon_decode_complete_ || !manifest_parse_complete_)
     return;
 
   if (error_.empty() && parsed_manifest_)
     delegate_->OnWebstoreParseSuccess(id_, icon_, parsed_manifest_.release());
   else
     delegate_->OnWebstoreParseFailure(id_, parse_error_, error_);
 }
 
 }  // namespace extensions