Network traffic annotation added to chrome::BitmapFetcher.

chrome/browser/extensions/webstore_install_helper.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/webstore_install_helper.h"
 
 #include "base/bind.h"
 #include "base/values.h"
 #include "chrome/browser/bitmap_fetcher/bitmap_fetcher.h"
 #include "components/safe_json/safe_json_parser.h"
 #include "content/public/browser/browser_thread.h"
 #include "net/base/load_flags.h"
+#include "net/traffic_annotation/network_traffic_annotation.h"
 #include "net/url_request/url_request.h"
 
 using content::BrowserThread;
 
 namespace {
 
 const char kImageDecodeError[] = "Image decode failed";
 
 }  // namespace
 
@@ skipping 23 matching lines @@
   safe_json::SafeJsonParser::Parse(
       manifest_, base::Bind(&WebstoreInstallHelper::OnJSONParseSucceeded, this),
       base::Bind(&WebstoreInstallHelper::OnJSONParseFailed, this));
 
   if (icon_url_.is_empty()) {
     icon_decode_complete_ = true;
   } else {
     // No existing |icon_fetcher_| to avoid unbalanced AddRef().
     CHECK(!icon_fetcher_.get());
     AddRef();  // Balanced in OnFetchComplete().
-    icon_fetcher_.reset(new chrome::BitmapFetcher(icon_url_, this));
+    net::NetworkTrafficAnnotationTag traffic_annotation =
+        net::DefineNetworkTrafficAnnotation("", R"(
+          semantics {
+            sender: ""

[Devlin, 2017/02/13 23:35:56]

Webstore Install Helper

[Ramin Halavati, 2017/02/14 10:05:54]

Done.

+            description: ""

[Devlin, 2017/02/13 23:35:56]

Fetches the bitmap corresponding to an extension icon.

[Ramin Halavati, 2017/02/14 10:05:54]

Done.

+            trigger: ""

[Devlin, 2017/02/13 23:35:56]

This can happen in a few different circumstances:
User initiated an install from the Chrome Web Store
User initiated an inline installation from another website
...Something with kiosk apps - maybe steel@ knows more about that one.

[Ramin Halavati, 2017/02/14 10:05:54]

Done.

+            data: ""

[Devlin, 2017/02/13 23:35:56]

The url of the icon for the extension, which includes the extension id
(potentially PII).

[Ramin Halavati, 2017/02/14 10:05:54]

Done.

+            destination: WEBSITE/GOOGLE_OWNED_SERVICE/OTHER

[Devlin, 2017/02/13 23:35:56]

Chrome Web Store == GOOGLE_OWNED_SERVICE.

[Ramin Halavati, 2017/02/14 10:05:54]

Done.

+          }
+          policy {
+            cookies_allowed: false/true

[Devlin, 2017/02/13 23:35:56]

Good question - how would we determine this?

[Ramin Halavati, 2017/02/14 10:05:54]

In current case, it is specified in the icon_fetcher_->Init() call, where
net::LOAD_DO_NOT_SAVE_COOKIES and net::LOAD_DO_NOT_SEND_COOKIES are specified.
Hence I set it to false.

+            cookies_store_exceptions: ""
+            setting: ""

[Devlin, 2017/02/13 23:35:56]

There's no direct Chrome setting to disable this, but you could uninstall all
extensions and not install (or begin the installation flow for) any more.

[Ramin Halavati, 2017/02/14 10:05:54]

Done.

+            policy {
+              [POLICY_NAME] {
+                policy_options {mode: MANDATORY/RECOMMENDED/UNSET}

[Devlin, 2017/02/13 23:35:57]

I don't see policy_options in the traffic_annotation proto?

[Ramin Halavati, 2017/02/14 10:05:54]

The policy options are here:
https://cs.chromium.org/chromium/src/out/Debug/gen/components/policy/proto/cl...

And more description on policy settings is here:
http://dev.chromium.org/administrators/policy-list-3

[Devlin, 2017/02/15 00:36:08]

But what are the policy options indicative of?  There's quite a giant list
there, but what's the question here?

[Ramin Halavati, 2017/02/15 11:52:02]

The questions is if any of the policy options will disable this request.

+                value: ...
+              }
+            }
+          })");
+    icon_fetcher_.reset(
+        new chrome::BitmapFetcher(icon_url_, this, traffic_annotation));
     icon_fetcher_->Init(
         context_getter_, std::string(),
         net::URLRequest::CLEAR_REFERRER_ON_TRANSITION_FROM_SECURE_TO_INSECURE,
         net::LOAD_DO_NOT_SAVE_COOKIES | net::LOAD_DO_NOT_SEND_COOKIES);
     icon_fetcher_->Start();
   }
 }
 
 void WebstoreInstallHelper::OnFetchComplete(const GURL& url,
                                             const SkBitmap* image) {
@@ skipping 43 matching lines @@
   if (!icon_decode_complete_ || !manifest_parse_complete_)
     return;
 
   if (error_.empty() && parsed_manifest_)
     delegate_->OnWebstoreParseSuccess(id_, icon_, parsed_manifest_.release());
   else
     delegate_->OnWebstoreParseFailure(id_, parse_error_, error_);
 }
 
 }  // namespace extensions