Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2486)

Side by Side Diff: Source/core/svg/SVGGElement.cpp

Issue 268223003: Move InvalidationGuard/InstanceUpdateBlocker out of SVGElementInstance (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Perform the renames Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/svg/SVGForeignObjectElement.cpp ('k') | Source/core/svg/SVGGradientElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2007, 2008 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2007, 2008 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org>
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 ASSERT_NOT_REACHED(); 57 ASSERT_NOT_REACHED();
58 } 58 }
59 59
60 void SVGGElement::svgAttributeChanged(const QualifiedName& attrName) 60 void SVGGElement::svgAttributeChanged(const QualifiedName& attrName)
61 { 61 {
62 if (!isSupportedAttribute(attrName)) { 62 if (!isSupportedAttribute(attrName)) {
63 SVGGraphicsElement::svgAttributeChanged(attrName); 63 SVGGraphicsElement::svgAttributeChanged(attrName);
64 return; 64 return;
65 } 65 }
66 66
67 SVGElementInstance::InvalidationGuard invalidationGuard(this); 67 SVGElement::InvalidationGuard invalidationGuard(this);
68 68
69 if (RenderObject* renderer = this->renderer()) 69 if (RenderObject* renderer = this->renderer())
70 RenderSVGResource::markForLayoutAndParentResourceInvalidation(renderer); 70 RenderSVGResource::markForLayoutAndParentResourceInvalidation(renderer);
71 } 71 }
72 72
73 RenderObject* SVGGElement::createRenderer(RenderStyle* style) 73 RenderObject* SVGGElement::createRenderer(RenderStyle* style)
74 { 74 {
75 // SVG 1.1 testsuite explicitely uses constructs like <g display="none"><lin earGradient> 75 // SVG 1.1 testsuite explicitely uses constructs like <g display="none"><lin earGradient>
76 // We still have to create renderers for the <g> & <linearGradient> element, though the 76 // We still have to create renderers for the <g> & <linearGradient> element, though the
77 // subtree may be hidden - we only want the resource renderers to exist so t hey can be 77 // subtree may be hidden - we only want the resource renderers to exist so t hey can be
78 // referenced from somewhere else. 78 // referenced from somewhere else.
79 if (style->display() == NONE) 79 if (style->display() == NONE)
80 return new RenderSVGHiddenContainer(this); 80 return new RenderSVGHiddenContainer(this);
81 81
82 return new RenderSVGTransformableContainer(this); 82 return new RenderSVGTransformableContainer(this);
83 } 83 }
84 84
85 bool SVGGElement::rendererIsNeeded(const RenderStyle&) 85 bool SVGGElement::rendererIsNeeded(const RenderStyle&)
86 { 86 {
87 // Unlike SVGElement::rendererIsNeeded(), we still create renderers, even if 87 // Unlike SVGElement::rendererIsNeeded(), we still create renderers, even if
88 // display is set to 'none' - which is special to SVG <g> container elements . 88 // display is set to 'none' - which is special to SVG <g> container elements .
89 return parentOrShadowHostElement() && parentOrShadowHostElement()->isSVGElem ent(); 89 return parentOrShadowHostElement() && parentOrShadowHostElement()->isSVGElem ent();
90 } 90 }
91 91
92 } 92 }
OLDNEW
« no previous file with comments | « Source/core/svg/SVGForeignObjectElement.cpp ('k') | Source/core/svg/SVGGradientElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698