Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1098)

Unified Diff: third_party/WebKit/Source/core/fileapi/FileReaderSync.h

Issue 2682223006: Add a use counter and histogram to FileReaderSync. (Closed)
Patch Set: add new histogram to histograms.xml Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/fileapi/FileReaderSync.h
diff --git a/third_party/WebKit/Source/core/fileapi/FileReaderSync.h b/third_party/WebKit/Source/core/fileapi/FileReaderSync.h
index b6dc4cac0137e489aef0244cd3d45955eb50f87b..80e13829c48f57307695c76817d243b9c9c90c6b 100644
--- a/third_party/WebKit/Source/core/fileapi/FileReaderSync.h
+++ b/third_party/WebKit/Source/core/fileapi/FileReaderSync.h
@@ -49,7 +49,9 @@ class FileReaderSync final : public GarbageCollected<FileReaderSync>,
DEFINE_WRAPPERTYPEINFO();
public:
- static FileReaderSync* create() { return new FileReaderSync(); }
+ static FileReaderSync* create(ExecutionContext* context) {
+ return new FileReaderSync(context);
+ }
DOMArrayBuffer* readAsArrayBuffer(ScriptState*, Blob*, ExceptionState&);
String readAsBinaryString(ScriptState*, Blob*, ExceptionState&);
@@ -65,7 +67,7 @@ class FileReaderSync final : public GarbageCollected<FileReaderSync>,
DEFINE_INLINE_TRACE() {}
private:
- FileReaderSync();
+ FileReaderSync(ExecutionContext*);
kinuko 2017/02/10 00:41:38 nit: explicit
Marijn Kruisselbrink 2017/02/10 17:42:53 Done
void startLoading(ExecutionContext*,
FileReaderLoader&,

Powered by Google App Engine
This is Rietveld 408576698