Convert NavigationController unit and browser tests to use the new navigation callbacks.

content/browser/frame_host/navigation_handle_impl.h

Index: content/browser/frame_host/navigation_handle_impl.h
diff --git a/content/browser/frame_host/navigation_handle_impl.h b/content/browser/frame_host/navigation_handle_impl.h
index 74b629e6f67bcbf531b4b8024fefac27089dbe63..9fac29e62fc6c0696c394e6d3fdf722c06e6e7a9 100644
--- a/content/browser/frame_host/navigation_handle_impl.h
+++ b/content/browser/frame_host/navigation_handle_impl.h
@@ -24,6 +24,7 @@
 #include "content/public/browser/global_request_id.h"
 #include "content/public/browser/navigation_data.h"
 #include "content/public/browser/navigation_throttle.h"
+#include "content/public/browser/navigation_type.h"
 #include "content/public/browser/ssl_status.h"
 #include "content/public/common/request_context_type.h"
 #include "third_party/WebKit/public/platform/WebMixedContentContextType.h"
@@ -289,6 +290,7 @@ class CONTENT_EXPORT NavigationHandleImpl : public NavigationHandle {
       const FrameHostMsg_DidCommitProvisionalLoad_Params& params,
       bool did_replace_entry,
       const GURL& previous_url,
+      NavigationType navigation_type,
       RenderFrameHostImpl* render_frame_host);
 
   // Called during commit. Takes ownership of the embedder's NavigationData
@@ -314,6 +316,8 @@ class CONTENT_EXPORT NavigationHandleImpl : public NavigationHandle {
     searchable_form_encoding_ = encoding;
   }
 
+  NavigationType navigation_type() { return navigation_type_; }

[nasko, 2017/02/09 00:29:11]

Since this is set at commit time, shouldn't we DCHECK the state to ensure
callers don't do it earlier?

[jam, 2017/02/09 01:15:03]

Done.

+
   void set_response_headers_for_testing(
       scoped_refptr<net::HttpResponseHeaders> response_headers) {
     response_headers_ = response_headers;
@@ -481,6 +485,7 @@ class CONTENT_EXPORT NavigationHandleImpl : public NavigationHandle {
   GURL previous_url_;
   GURL base_url_;
   net::HostPortPair socket_address_;
+  NavigationType navigation_type_;
 
   base::WeakPtrFactory<NavigationHandleImpl> weak_factory_;