Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2682113003: Revert "Use ProcedureKind.Operator for operators." (Closed)

Created:
3 years, 10 months ago by ahe
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Use ProcedureKind.Operator for operators." This reverts commit 025ad56fccebd1b479be85014ccbdee8c360b9b4. Revert "Add enum for user-definable operators." This reverts commit 91bea04dcb537cfddd137ccbcf5b4988de0b74ab. Committed: https://github.com/dart-lang/sdk/commit/98c93c3c926b1f1cacb590131f08480b1cb07550

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -277 lines) Patch
D pkg/front_end/lib/src/fasta/operator.dart View 1 chunk +0 lines, -80 lines 2 comments Download
M pkg/front_end/lib/src/fasta/source/outline_builder.dart View 3 chunks +8 lines, -22 lines 0 comments Download
M pkg/front_end/test/fasta/compile.status View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/front_end/test/fasta/kompile.status View 1 chunk +0 lines, -1 line 0 comments Download
D pkg/front_end/test/fasta/operators.dart View 1 chunk +0 lines, -51 lines 0 comments Download
D pkg/front_end/test/fasta/operators.dart.direct.expect View 1 chunk +0 lines, -72 lines 0 comments Download
D pkg/front_end/test/fasta/operators.dart.outline.expect View 1 chunk +0 lines, -50 lines 0 comments Download
M pkg/front_end/test/fasta/outline.status View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/issue_000053.dart.outline.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/test/fasta/testing.json View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
ahe
TBR https://codereview.chromium.org/2682113003/diff/1/pkg/front_end/lib/src/fasta/operator.dart File pkg/front_end/lib/src/fasta/operator.dart (left): https://codereview.chromium.org/2682113003/diff/1/pkg/front_end/lib/src/fasta/operator.dart#oldcode20 pkg/front_end/lib/src/fasta/operator.dart:20: index, "index" is also a static method on ...
3 years, 10 months ago (2017-02-08 14:44:16 UTC) #2
ahe
Committed patchset #1 (id:1) manually as 98c93c3c926b1f1cacb590131f08480b1cb07550 (presubmit successful).
3 years, 10 months ago (2017-02-08 14:44:31 UTC) #4
Lasse Reichstein Nielsen
3 years, 10 months ago (2017-02-08 14:48:44 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/2682113003/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/operator.dart (left):

https://codereview.chromium.org/2682113003/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/operator.dart:20: index,
Enums suck. 'nuff said.

Powered by Google App Engine
This is Rietveld 408576698